Show proper error instead of redirecting to signup form when a user tries to view invalid member info

This commit is contained in:
Kijin Sung 2023-06-29 01:39:10 +09:00
parent b53e8adad7
commit 05bab8e7f8

View file

@ -125,17 +125,18 @@ class MemberView extends Member
throw new Rhymix\Framework\Exceptions\MustLogin; throw new Rhymix\Framework\Exceptions\MustLogin;
} }
$member_srl = Context::get('member_srl'); $member_srl = Context::get('member_srl') ?: $logged_info->member_srl;
if(!$member_srl && Context::get('is_logged')) if(!$member_srl)
{ {
$member_srl = $logged_info->member_srl; throw new Rhymix\Framework\Exceptions\MustLogin;
}
elseif(!$member_srl)
{
return $this->dispMemberSignUpForm();
} }
$member_info = MemberModel::getMemberInfoByMemberSrl($member_srl); $member_info = MemberModel::getMemberInfoByMemberSrl($member_srl);
if (!$member_info->member_srl)
{
throw new Rhymix\Framework\Exceptions\TargetNotFound;
}
unset($member_info->password); unset($member_info->password);
unset($member_info->email_id); unset($member_info->email_id);
unset($member_info->email_host); unset($member_info->email_host);
@ -147,8 +148,6 @@ class MemberView extends Member
$member_info->email_address = sprintf('%s@%s', $protect_id, $email_host); $member_info->email_address = sprintf('%s@%s', $protect_id, $email_host);
} }
if(!$member_info->member_srl) return $this->dispMemberSignUpForm();
Context::set('memberInfo', get_object_vars($member_info)); Context::set('memberInfo', get_object_vars($member_info));
$extendForm = MemberModel::getCombineJoinForm($member_info); $extendForm = MemberModel::getCombineJoinForm($member_info);