From 0b317e11685a6eca4cbc596ebde92879b201d2d1 Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Fri, 18 Dec 2020 21:40:02 +0900 Subject: [PATCH] Fix #1496 close PHP tag in case a rogue module tries to append stuff to menu cache file --- modules/menu/menu.admin.controller.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/menu/menu.admin.controller.php b/modules/menu/menu.admin.controller.php index 94f74d239..780896681 100644 --- a/modules/menu/menu.admin.controller.php +++ b/modules/menu/menu.admin.controller.php @@ -1841,7 +1841,7 @@ class menuAdminController extends menu 'header("Cache-Control: post-check=0, pre-check=0", false);' . PHP_EOL . 'header("Pragma: no-cache");' . PHP_EOL . '%s' . PHP_EOL . - '$oContext->close();' . PHP_EOL . + '$oContext->close(); ?' . '>' . PHP_EOL . '%s', $header_script, $this->getXmlTree($tree[0], $tree, $site_srl, $domain) @@ -1857,7 +1857,7 @@ class menuAdminController extends menu '%s; ' . PHP_EOL . '$menu->list = array(%s); ' . PHP_EOL . 'if(!$is_admin) { recurciveExposureCheck($menu->list); }' . PHP_EOL . - 'Context::set("included_menu", $menu); ' . PHP_EOL, + 'Context::set("included_menu", $menu); ?' . '>' . PHP_EOL, $header_script, $php_output['name'], $php_output['buff']