From 0ba4c51c3c090e9e354b3c6f6cec1b1a055051dd Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Mon, 16 Jan 2023 21:39:30 +0900 Subject: [PATCH] Fix type error in DBHelper::query() when there is a query error --- common/framework/helpers/DBHelper.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/framework/helpers/DBHelper.php b/common/framework/helpers/DBHelper.php index 4e4029683..b38a2c39b 100644 --- a/common/framework/helpers/DBHelper.php +++ b/common/framework/helpers/DBHelper.php @@ -86,10 +86,10 @@ class DBHelper extends \PDO * * @param string $statement * @param int $fetch_mode - * @return DBStmtHelper + * @return DBStmtHelper|false */ #[\ReturnTypeWillChange] - public function query(string $statement, ?int $fetch_mode = \PDO::FETCH_OBJ, ...$fetch_mode_args): DBStmtHelper + public function query(string $statement, ?int $fetch_mode = \PDO::FETCH_OBJ, ...$fetch_mode_args) { $start_time = microtime(true); $db_class = DB::getInstance($this->_type); @@ -110,6 +110,7 @@ class DBHelper extends \PDO } catch (\PDOException $e) { + $stmt = false; $db_class->setError(-1, $e->getMessage()); } finally