fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-11 04:52:14 +09:00
Code Issues Projects Releases Packages Wiki Activity

Use SELECT ... FOR UPDATE to guard against race conditions in DB queue driver

Browse source
This commit is contained in:
Kijin Sung 2024-10-12 01:22:04 +09:00
parent f1eee10791
commit 0ee9747a22
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
common/framework/drivers/queue/db.php
View file

@ -96,7 +96,8 @@ class DB implements QueueInterface
public function getTask(int $blocking = 0): ?object public function getTask(int $blocking = 0): ?object
{ {
$oDB = RFDB::getInstance(); $oDB = RFDB::getInstance();
$stmt = $oDB->query('SELECT * FROM task_queue ORDER BY id LIMIT 1'); $oDB->beginTransaction();
$stmt = $oDB->query('SELECT * FROM task_queue ORDER BY id LIMIT 1 FOR UPDATE');
$result = $stmt->fetchObject(); $result = $stmt->fetchObject();
$stmt->closeCursor(); $stmt->closeCursor();
@ -104,6 +105,7 @@ class DB implements QueueInterface
{ {
$stmt = $oDB->prepare('DELETE FROM task_queue WHERE id = ?'); $stmt = $oDB->prepare('DELETE FROM task_queue WHERE id = ?');
$stmt->execute([$result->id]); $stmt->execute([$result->id]);
$oDB->commit();
$result->args = unserialize($result->args); $result->args = unserialize($result->args);
$result->options = unserialize($result->options); $result->options = unserialize($result->options);
@ -111,6 +113,7 @@ class DB implements QueueInterface
} }
else else
{ {
$oDB->commit();
return null; return null;
} }
} }