From 23678b790b96749eadc393a891f6c1928d0b7fe2 Mon Sep 17 00:00:00 2001 From: ucorina Date: Fri, 23 Sep 2011 09:15:30 +0000 Subject: [PATCH] Issue 182 - Update query argument ignored when value is 0. git-svn-id: http://xe-core.googlecode.com/svn/branches/1.5.0@9314 201d5d3c-b55e-5fd7-737f-ddc643e51545 --- .../queryparts/expression/UpdateExpression.class.php | 3 ++- test-phpUnit/db/xml_query/cubrid/CubridUpdateTest.php | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/classes/db/queryparts/expression/UpdateExpression.class.php b/classes/db/queryparts/expression/UpdateExpression.class.php index 41a36b7dd..067239e34 100644 --- a/classes/db/queryparts/expression/UpdateExpression.class.php +++ b/classes/db/queryparts/expression/UpdateExpression.class.php @@ -44,7 +44,8 @@ function show(){ if(!$this->argument) return false; - if(!$this->argument->getValue()) return false; + $value = $this->argument->getValue(); + if(!isset($value)) return false; return true; } diff --git a/test-phpUnit/db/xml_query/cubrid/CubridUpdateTest.php b/test-phpUnit/db/xml_query/cubrid/CubridUpdateTest.php index 23f19d5c8..803815707 100644 --- a/test-phpUnit/db/xml_query/cubrid/CubridUpdateTest.php +++ b/test-phpUnit/db/xml_query/cubrid/CubridUpdateTest.php @@ -66,6 +66,17 @@ $this->_test($xml_file, $argsString, $expected); } + + function test_menu_updateMenuItemNode(){ + $xml_file = _XE_PATH_ . "modules/menu/queries/updateMenuItemNode.xml"; + $argsString = '$args->parent_srl = 0; + $args->menu_srl = 237423; + $args->listorder = -8; + $args->menu_item_srl = 237431;'; + $expected = 'UPDATE "xe_menu_item" SET "parent_srl" = 0, "listorder" = -8 WHERE "menu_item_srl" = 237431'; + $this->_test($xml_file, $argsString, $expected); + } + // $queryTester->test_admin_deleteActionForward(); // $queryTester->test_module_insertModule();