diff --git a/modules/admin/admin.admin.controller.php b/modules/admin/admin.admin.controller.php
index 2d6cd56b3..80853daa4 100644
--- a/modules/admin/admin.admin.controller.php
+++ b/modules/admin/admin.admin.controller.php
@@ -154,24 +154,23 @@
{
$siteSrl = Context::get('site_srl');
$moduleName = Context::get('module_name');
- $key = Context::get('key');
// check favorite exists
$oModel = &getAdminModel('admin');
- $output = $oModel->isExistsFavorite($siteSrl, $moduleName, $key);
+ $output = $oModel->isExistsFavorite($siteSrl, $moduleName);
if (!$output->toBool()) return $output;
// if exists, delete favorite
if ($output->get('result'))
{
$favoriteSrl = $output->get('favoriteSrl');
- $output = $this->deleteFavorite($favoriteSrl);
+ $output = $this->_deleteFavorite($favoriteSrl);
}
// if not exists, insert favorite
else
{
- $output = $this->insertFavorite($siteSrl, $moduleName, $key);
+ $output = $this->_insertFavorite($siteSrl, $moduleName);
}
if (!$output->toBool()) return $output;
@@ -261,11 +260,10 @@
/**
* @brief Insert favorite
**/
- function insertFavorite($siteSrl, $module, $key)
+ function _insertFavorite($siteSrl, $module)
{
$args->site_srl = $siteSrl;
$args->module = $module;
- $args->key = $key;
$output = executeQuery('admin.insertFavorite', $args);
return $output;
}
@@ -273,71 +271,13 @@
/**
* @brief Delete favorite
**/
- function deleteFavorite($favoriteSrl)
+ function _deleteFavorite($favoriteSrl)
{
$args->admin_favorite_srl = $favoriteSrl;
$output = executeQuery('admin.deleteFavorite', $args);
return $output;
}
- /**
- * @brief set favorites at one time
- **/
- function setFavoritesByModule($siteSrl, $module, $keyList)
- {
- $oModel = &getAdminModel('admin');
- $output = $oModel->getFavoriteListByModule($siteSrl, $module);
- if (!$output->toBool()) return $output;
- $originList = $output->get('list');
-
- // find insert key
- $insertKey = array_diff($keyList, $originList);
-
- // find delete key
- $deleteKey = array_diff($originList, $keyList);
-
- // start transaction
- $oDB = &DB::getInstance();
- $oDB->begin();
-
- // insert key
- foreach($insertKey as $key)
- {
- $output = $this->insertFavorite($siteSrl, $module, $key);
- if (!$output->toBool())
- {
- $oDB->rollback();
- return $output;
- }
- }
-
- // delete key
- foreach($deleteKey as $key)
- {
- $output = $oModel->isExistsFavorite($siteSrl, $module, $key);
- if (!$output->toBool())
- {
- $oDB->rollback();
- return $output;
- }
- $favoriteSrl = $output->get('favoriteSrl');
-
- if ($favoriteSrl)
- {
- $output = $this->deleteFavorite($favoriteSrl);
- if (!$output->toBool())
- {
- $oDB->rollback();
- return $output;
- }
- }
- }
-
- // commit
- $oDB->commit();
-
- return new Object();
- }
function procAdminRemoveIcons(){
$iconname = Context::get('iconname');
$file_exist = FileHandler::readFile(_XE_PATH_.'files/attach/xeicon/'.$iconname);
diff --git a/modules/admin/admin.admin.model.php b/modules/admin/admin.admin.model.php
index a1d9a67c0..1c17a1aaa 100644
--- a/modules/admin/admin.admin.model.php
+++ b/modules/admin/admin.admin.model.php
@@ -341,17 +341,6 @@
if (!$output->toBool()) return $output;
if (!$output->data) return new Object();
- foreach($output->data as $row)
- {
- $targetModule = $row->module;
- $oTargetModuleAdminModel = &getAdminModel($targetModule);
- if (!$oTargetModuleAdminModel) continue;
- if (!method_exists($oTargetModuleAdminModel, 'getFavoriteInfo')) continue;
-
- $favoriteInfo = $oTargetModuleAdminModel->getFavoriteInfo($row->key);
- $favoriteList[] = $favoriteInfo;
- }
-
$returnObject = new Object();
$returnObject->add('favoriteList', $favoriteList);
return $returnObject;
@@ -360,11 +349,10 @@
/**
* @brief Check available insert favorite
**/
- function isExistsFavorite($siteSrl, $module, $key)
+ function isExistsFavorite($siteSrl, $module)
{
$args->site_srl = $siteSrl;
$args->module = $module;
- $args->key = $key;
$output = executeQuery('admin.getFavorite', $args);
if (!$output->toBool()) return $output;
@@ -382,29 +370,6 @@
return $returnObject;
}
- /**
- * @brief Get favorite by module, site
- **/
- function getFavoriteListByModule($siteSrl, $module)
- {
- $args->site_srl = $siteSrl;
- $args->module = $module;
- $columnList = array('key');
- $output = executeQueryArray('admin.getFavoriteList', $args, $columnList);
- if (!$output->toBool()) return $output;
- if (!$output->data) $output->data = array();
-
- $list = array();
- foreach($output->data as $row)
- {
- $list[$row->key] = $row->key;
- }
-
- $returnObject = new Object();
- $returnObject->add('list', $list);
- return $returnObject;
- }
-
/**
* @brief Return site list
**/
diff --git a/modules/admin/queries/getFavorite.xml b/modules/admin/queries/getFavorite.xml
index 0911c38b9..9d7e9f850 100644
--- a/modules/admin/queries/getFavorite.xml
+++ b/modules/admin/queries/getFavorite.xml
@@ -9,7 +9,6 @@
-
diff --git a/modules/admin/queries/insertFavorite.xml b/modules/admin/queries/insertFavorite.xml
index d6f21b41e..6a878bcdc 100644
--- a/modules/admin/queries/insertFavorite.xml
+++ b/modules/admin/queries/insertFavorite.xml
@@ -5,6 +5,5 @@
-
diff --git a/modules/admin/schemas/admin_favorite.xml b/modules/admin/schemas/admin_favorite.xml
index 987286bff..04d273008 100644
--- a/modules/admin/schemas/admin_favorite.xml
+++ b/modules/admin/schemas/admin_favorite.xml
@@ -1,6 +1,5 @@
\ No newline at end of file
+