diff --git a/classes/display/DisplayHandler.class.php b/classes/display/DisplayHandler.class.php index d98f250ed..bffe15e19 100644 --- a/classes/display/DisplayHandler.class.php +++ b/classes/display/DisplayHandler.class.php @@ -83,7 +83,7 @@ class DisplayHandler extends Handler // header output $httpStatusCode = $oModule->getHttpStatusCode(); - if($httpStatusCode && $httpStatusCode != 200 && !in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON', 'JS_CALLBACK'))) + if($httpStatusCode !== 200 && !in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON', 'JS_CALLBACK'))) { self::_printHttpStatusCode($httpStatusCode); } diff --git a/classes/module/ModuleHandler.class.php b/classes/module/ModuleHandler.class.php index 7206adc91..243cd9321 100644 --- a/classes/module/ModuleHandler.class.php +++ b/classes/module/ModuleHandler.class.php @@ -925,7 +925,7 @@ class ModuleHandler extends Handler $oMessageObject->dispMessage(); // display Error Page - if($oMessageObject->getHttpStatusCode() && !in_array($oMessageObject->getHttpStatusCode(), array('200', '403'))) + if(!in_array($oMessageObject->getHttpStatusCode(), array(200, 403))) { $oMessageObject->setTemplateFile('http_status_code'); } @@ -1062,7 +1062,7 @@ class ModuleHandler extends Handler } // Set http status code - if($this->httpStatusCode && (!$oModule->getHttpStatusCode() || $oModule->getHttpStatusCode() == '200')) + if($this->httpStatusCode && $oModule->getHttpStatusCode() === 200) { $oModule->setHttpStatusCode($this->httpStatusCode); } diff --git a/classes/object/Object.class.php b/classes/object/Object.class.php index 9fbb9c491..2715a579a 100644 --- a/classes/object/Object.class.php +++ b/classes/object/Object.class.php @@ -31,7 +31,7 @@ class Object * http status code. * @var int */ - var $httpStatusCode = NULL; + var $httpStatusCode = 200; /** * Constructor @@ -73,9 +73,9 @@ class Object * @param int $code HTTP status code. Default value is `200` that means successful * @return void */ - function setHttpStatusCode($code = '200') + function setHttpStatusCode($code = 200) { - $this->httpStatusCode = $code; + $this->httpStatusCode = (int) $code; } /** diff --git a/modules/board/board.view.php b/modules/board/board.view.php index 2646aedd2..c6db99834 100644 --- a/modules/board/board.view.php +++ b/modules/board/board.view.php @@ -1138,7 +1138,7 @@ class boardView extends board { Context::set('message', lang($msg_code)); - $this->setHttpStatusCode('403'); + $this->setHttpStatusCode(403); $this->setTemplateFile('message'); } @@ -1191,7 +1191,7 @@ class boardView extends board $script = sprintf('', lang($message)); Context::addHtmlFooter($script); - $this->setHttpStatusCode('403'); + $this->setHttpStatusCode(403); } } diff --git a/modules/message/message.mobile.php b/modules/message/message.mobile.php index d08f2b85a..422c3f3fa 100644 --- a/modules/message/message.mobile.php +++ b/modules/message/message.mobile.php @@ -46,9 +46,9 @@ class messageMobile extends messageView $this->setTemplateFile('system_message'); // Default 403 Error - if(!$this->getHttpStatusCode() || $this->getHttpStatusCode() == '200') + if($this->getHttpStatusCode() === 200) { - $this->setHttpStatusCode('403'); + $this->setHttpStatusCode(403); } } } diff --git a/modules/message/message.view.php b/modules/message/message.view.php index b4d3e6c6c..fd3169eec 100644 --- a/modules/message/message.view.php +++ b/modules/message/message.view.php @@ -55,9 +55,9 @@ class messageView extends message $this->setTemplateFile('system_message'); // Default 403 Error - if(!$this->getHttpStatusCode() || $this->getHttpStatusCode() == '200') + if($this->getHttpStatusCode() === 200) { - $this->setHttpStatusCode('403'); + $this->setHttpStatusCode(403); } } }