From 2d1ff01688f0310ed04ea53f97fd11b787c27ade Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Tue, 16 Jan 2024 21:30:27 +0900
Subject: [PATCH] Fix #2271 data-file-srl attribute of <video> and <audio> tags

---
 common/framework/filters/HTMLFilter.php         | 2 ++
 tests/unit/framework/filters/HTMLFilterTest.php | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/common/framework/filters/HTMLFilter.php b/common/framework/filters/HTMLFilter.php
index a64e3d757..8833bafc7 100644
--- a/common/framework/filters/HTMLFilter.php
+++ b/common/framework/filters/HTMLFilter.php
@@ -353,6 +353,8 @@ class HTMLFilter
 
 		// Support editor components and widgets.
 		$def->addAttribute('img', 'data-file-srl', 'Number');
+		$def->addAttribute('video', 'data-file-srl', 'Number');
+		$def->addAttribute('audio', 'data-file-srl', 'Number');
 		$def->addAttribute('img', 'editor_component', 'Text');
 		$def->addAttribute('div', 'editor_component', 'Text');
 		$def->addAttribute('img', 'rx_encoded_properties', 'Text');
diff --git a/tests/unit/framework/filters/HTMLFilterTest.php b/tests/unit/framework/filters/HTMLFilterTest.php
index 32fdf5208..79c18a9b5 100644
--- a/tests/unit/framework/filters/HTMLFilterTest.php
+++ b/tests/unit/framework/filters/HTMLFilterTest.php
@@ -273,6 +273,14 @@ class HTMLFilterTest extends \Codeception\Test\Unit
 		$target = '<p><img src="foo.jpg" alt="foobar" /></p>';
 		$this->assertEquals($target, Rhymix\Framework\Filters\HTMLFilter::clean($source));
 
+		$source = '<video src="foo.mp4" poster="foo.jpg" data-file-srl="1234"></video>';
+		$target = '<video src="foo.mp4" poster="foo.jpg" data-file-srl="1234"></video>';
+		$this->assertEquals($target, Rhymix\Framework\Filters\HTMLFilter::clean($source));
+
+		$source = '<audio src="foo.mp3" invalid="" data-file-srl="1234"></audio>';
+		$target = '<audio src="foo.mp3" data-file-srl="1234"></audio>';
+		$this->assertEquals($target, Rhymix\Framework\Filters\HTMLFilter::clean($source));
+
 		// Other data-* attribute
 		$source = '<div data-foo="foobar" data-bar="bazz" style="width:100%;">Hello World</div>';
 		$target = '<div style="width:100%;" data-foo="foobar" data-bar="bazz">Hello World</div>';