From 372e392049d260349ce38c394e57b149c1ef4afd Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Fri, 11 Dec 2020 21:38:39 +0900
Subject: [PATCH] Fix #1480 misc errors in PHP 8.0

---
 modules/autoinstall/tpl/list.html                           | 2 +-
 modules/file/file.admin.controller.php                      | 2 +-
 .../integration_search.admin.controller.php                 | 2 +-
 modules/member/tpl/login_config.html                        | 6 +++---
 modules/poll/poll.admin.view.php                            | 5 ++++-
 modules/widget/widget.controller.php                        | 6 +++---
 6 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/modules/autoinstall/tpl/list.html b/modules/autoinstall/tpl/list.html
index 7acac067e..7d1ce5a99 100644
--- a/modules/autoinstall/tpl/list.html
+++ b/modules/autoinstall/tpl/list.html
@@ -173,7 +173,7 @@
 		<li class="x_disabled"|cond="$page == $page_navigation->last_page"><a href="{getUrl('page', $page_navigation->last_page)}" title="{$page_navigation->last_page}">{$lang->last_page} &raquo;</a></li>
 		</ul>
 	</form>
-	<form action="./" class="search x_input-append x_pull-right" no-error-return-url="true" cond="$act!=dispAutoinstallAdminInstalledPackages">
+	<form action="./" class="search x_input-append x_pull-right" no-error-return-url="true" cond="$act !== 'dispAutoinstallAdminInstalledPackages'">
 		<input type="hidden" name="module" value="admin" />
 		<input type="hidden" name="act" value="{$act}" />
 		<input type="hidden" name="order_target" value="{$order_target}" />
diff --git a/modules/file/file.admin.controller.php b/modules/file/file.admin.controller.php
index 0b93d6c54..a42771988 100644
--- a/modules/file/file.admin.controller.php
+++ b/modules/file/file.admin.controller.php
@@ -132,7 +132,7 @@ class fileAdminController extends file
 		$config->allow_outlink_site = Context::get('allow_outlink_site');
 		$config->allow_multimedia_direct_download = Context::get('allow_multimedia_direct_download') === 'Y' ? 'Y' : 'N';
 		$config->download_short_url = Context::get('download_short_url') === 'Y' ? 'Y' : 'N';
-		$config->inline_download_format = array_map('utf8_trim', Context::get('inline_download_format'));
+		$config->inline_download_format = array_map('utf8_trim', Context::get('inline_download_format') ?: []);
 		
 		// Save and redirect
 		$output = getController('module')->insertModuleConfig('file', $config);
diff --git a/modules/integration_search/integration_search.admin.controller.php b/modules/integration_search/integration_search.admin.controller.php
index 7d2ab6bb8..c31e8c3ab 100644
--- a/modules/integration_search/integration_search.admin.controller.php
+++ b/modules/integration_search/integration_search.admin.controller.php
@@ -25,7 +25,7 @@ class integration_searchAdminController extends integration_search
 	{
 		// Get configurations (using module model object)
 		$oModuleModel = getModel('module');
-		$config = $oModuleModel->getModuleConfig('integration_search');
+		$config = $oModuleModel->getModuleConfig('integration_search') ?: new stdClass;
 		$config = (object)get_object_vars($config);
 
 		$config->skin = Context::get('skin');
diff --git a/modules/member/tpl/login_config.html b/modules/member/tpl/login_config.html
index e349d5ebd..3345c4bca 100644
--- a/modules/member/tpl/login_config.html
+++ b/modules/member/tpl/login_config.html
@@ -8,15 +8,15 @@
 		<p class="x_control-label">{$lang->identifier}</p>
 		<div class="x_controls">
 			<label class="x_inline" for="identifiers_user_id">
-				<input type="checkbox" name="identifiers[]" id="identifiers_user_id" value="user_id" checked="checked"|cond="$config->identifier === 'user_id' || in_array('user_id', $config->identifiers)" />
+				<input type="checkbox" name="identifiers[]" id="identifiers_user_id" value="user_id" checked="checked"|cond="$config->identifier === 'user_id' || (is_array($config->identifiers) && in_array('user_id', $config->identifiers))" />
 				{$lang->user_id}
 			</label>
 			<label class="x_inline" for="identifiers_email_address">
-				<input type="checkbox" name="identifiers[]" id="identifiers_email_address" value="email_address" checked="checked"|cond="$config->identifier === 'email_address' || in_array('email_address', $config->identifiers)" />
+				<input type="checkbox" name="identifiers[]" id="identifiers_email_address" value="email_address" checked="checked"|cond="$config->identifier === 'email_address' || (is_array($config->identifiers) && in_array('email_address', $config->identifiers))" />
 				{$lang->email_address}
 			</label>
 			<label class="x_inline" for="identifiers_phone_number">
-				<input type="checkbox" name="identifiers[]" id="identifiers_phone_number" value="phone_number" checked="checked"|cond="$config->identifier === 'phone_number' || in_array('phone_number', $config->identifiers)" />
+				<input type="checkbox" name="identifiers[]" id="identifiers_phone_number" value="phone_number" checked="checked"|cond="$config->identifier === 'phone_number' || (is_array($config->identifiers) && in_array('phone_number', $config->identifiers))" />
 				{$lang->phone_number}
 			</label>
 			<p class="x_help-block">{$lang->about_identifier}</p>
diff --git a/modules/poll/poll.admin.view.php b/modules/poll/poll.admin.view.php
index 8277a8208..6ff37c4c7 100644
--- a/modules/poll/poll.admin.view.php
+++ b/modules/poll/poll.admin.view.php
@@ -50,6 +50,10 @@ class pollAdminView extends poll
 		// Get the list
 		$oPollAdminModel = getAdminModel('poll');
 		$output = $oPollAdminModel->getPollListWithMember($args);
+		if (!$output->toBool())
+		{
+			return $output;
+		}
 
 		// check poll type. document or comment
 		if(is_array($output->data) && count($output->data))
@@ -88,7 +92,6 @@ class pollAdminView extends poll
 		Context::set('page', $output->page);
 		Context::set('poll_list', $output->data);
 		Context::set('page_navigation', $output->page_navigation);
-		Context::set('module_list', $module_list);
 
 		$security = new Security();
 		$security->encodeHTML('poll_list..title', 'poll_list..nick_name');
diff --git a/modules/widget/widget.controller.php b/modules/widget/widget.controller.php
index 3f807929b..b19cda552 100644
--- a/modules/widget/widget.controller.php
+++ b/modules/widget/widget.controller.php
@@ -31,10 +31,10 @@ class widgetController extends widget
 		$oModuleModel = getModel('module');
 		$skin_info = $oModuleModel->loadSkinInfo($path, $skin);
 
-		for($i=0;$i<count($skin_info->colorset);$i++)
+		$colorset_list = [];
+		foreach($skin_info->colorset ?: [] as $colorset)
 		{
-			$colorset = sprintf('%s|@|%s', $skin_info->colorset[$i]->name, $skin_info->colorset[$i]->title);
-			$colorset_list[] = $colorset;
+			$colorset_list[] = sprintf('%s|@|%s', $colorset->name, $colorset->title);
 		}
 
 		if(count($colorset_list)) $colorsets = implode("\n", $colorset_list);