fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-09 03:52:15 +09:00
Code Issues Projects Releases Packages Wiki Activity

Comment caching improvements.

Browse source 
git-svn-id: http://xe-core.googlecode.com/svn/branches/1.5.0@9789 201d5d3c-b55e-5fd7-737f-ddc643e51545
This commit is contained in:
ucorina 2011-11-02 17:13:36 +00:00
parent 97470e4d40
commit 41584ccd58
4 changed files with 24 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

13
modules/comment/comment.admin.controller.php
View file

@ -79,13 +79,6 @@
$oDB->commit(); $oDB->commit();
//remove from cache
$oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport())
{
$oCacheHandler->invalidateGroupKey('commentList');
}
$msgCode = ''; $msgCode = '';
if($isTrash == 'true') $msgCode = 'success_trashed'; if($isTrash == 'true') $msgCode = 'success_trashed';
else $msgCode = 'success_deleted'; else $msgCode = 'success_deleted';
@ -169,11 +162,13 @@
if(!$output->toBool()) return $output; if(!$output->toBool()) return $output;
$output = executeQuery('comment.deleteModuleCommentsList', $args); $output = executeQuery('comment.deleteModuleCommentsList', $args);
//remove from cache
//remove from cache
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()) if($oCacheHandler->isSupport())
{ {
$oCacheHandler->invalidateGroupKey('commentList'); // Invalidate newest comments. Per document cache is invalidated inside document admin controller.
$oCacheHandler->invalidateGroupKey('newestCommentsList');
} }
return $output; return $output;
} }

12
modules/comment/comment.controller.php
View file

@ -244,7 +244,8 @@
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()) if($oCacheHandler->isSupport())
{ {
$oCacheHandler->invalidateGroupKey('commentList'); $oCacheHandler->invalidateGroupKey('commentList_' . $document_srl);
$oCacheHandler->invalidateGroupKey('newestCommentsList');
} }
return $output; return $output;
} }
@ -326,7 +327,8 @@
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()) if($oCacheHandler->isSupport())
{ {
$oCacheHandler->invalidateGroupKey('commentList'); $oCacheHandler->invalidateGroupKey('commentList_' . $obj->document_srl);
$oCacheHandler->invalidateGroupKey('newestCommentsList');
} }
return $output; return $output;
} }
@ -395,7 +397,8 @@
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()) if($oCacheHandler->isSupport())
{ {
$oCacheHandler->invalidateGroupKey('commentList'); $oCacheHandler->invalidateGroupKey('commentList_' . $document_srl);
$oCacheHandler->invalidateGroupKey('newestCommentsList');
} }
return $output; return $output;
} }
@ -454,7 +457,8 @@
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()) if($oCacheHandler->isSupport())
{ {
$oCacheHandler->invalidateGroupKey('commentList'); $oCacheHandler->invalidateGroupKey('commentList_' . $document_srl);
$oCacheHandler->invalidateGroupKey('newestCommentsList');
} }
return $output; return $output;

20
modules/comment/comment.model.php
View file

@ -175,6 +175,7 @@
/** /**
* @brief get the comment in corresponding with mid. * @brief get the comment in corresponding with mid.
* TODO add commentItems to cache too
**/ **/
function getNewestCommentList($obj, $columnList = array()) { function getNewestCommentList($obj, $columnList = array()) {
if($obj->mid) { if($obj->mid) {
@ -190,7 +191,7 @@
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()){ if($oCacheHandler->isSupport()){
$object_key = 'object_newest_comment_list:'.$obj->module_srl; $object_key = 'object_newest_comment_list:'.$obj->module_srl;
$cache_key = $oCacheHandler->getGroupKey('commentList', $object_key); $cache_key = $oCacheHandler->getGroupKey('newestCommentsList', $object_key);
$output = $oCacheHandler->get($cache_key); $output = $oCacheHandler->get($cache_key);
} }
if(!$output){ if(!$output){
@ -220,17 +221,18 @@
* @brief get a comment list of the doc in corresponding woth document_srl. * @brief get a comment list of the doc in corresponding woth document_srl.
**/ **/
function getCommentList($document_srl, $page = 0, $is_admin = false, $count = 0) { function getCommentList($document_srl, $page = 0, $is_admin = false, $count = 0) {
if(!isset($document_srl)) return;
// cache controll // cache controll
$oCacheHandler = &CacheHandler::getInstance('object'); $oCacheHandler = &CacheHandler::getInstance('object');
if($oCacheHandler->isSupport()){ if($oCacheHandler->isSupport()){
$object_key = 'object:'.$document_srl.'_'.$page.'_'.($is_admin ? 'Y' : 'N') .'_' . $count; $object_key = 'object:'.$document_srl.'_'.$page.'_'.($is_admin ? 'Y' : 'N') .'_' . $count;
$cache_key = $oCacheHandler->getGroupKey('commentList', $object_key); $cache_key = $oCacheHandler->getGroupKey('commentList_' . $document_srl, $object_key);
$output = $oCacheHandler->get($cache_key); $output = $oCacheHandler->get($cache_key);
} }
if(!$output){ if(!$output){
// get the number of comments on the document module // get the number of comments on the document module
$oDocumentModel = &getModel('document'); $oDocumentModel = &getModel('document');
$columnList = array('document_srl', 'module_srl', 'comment_count'); $columnList = array('document_srl', 'module_srl', 'comment_count');
$oDocument = $oDocumentModel->getDocument($document_srl, false, true, $columnList); $oDocument = $oDocumentModel->getDocument($document_srl, false, true, $columnList);
// return if no doc exists. // return if no doc exists.
if(!$oDocument->isExists()) return; if(!$oDocument->isExists()) return;

1
modules/document/document.admin.controller.php
View file

@ -321,6 +321,7 @@
$oCacheHandler->delete($cache_key); $oCacheHandler->delete($cache_key);
$cache_key_item = 'object_document_item:'.$document_srl; $cache_key_item = 'object_document_item:'.$document_srl;
$oCacheHandler->delete($cache_key_item); $oCacheHandler->delete($cache_key_item);
$oCacheHandler->invalidateGroupKey('commentList_' . $document_srl);
} }
$oCacheHandler->invalidateGroupKey('documentList'); $oCacheHandler->invalidateGroupKey('documentList');
} }