fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-11 13:02:15 +09:00
Code Issues Projects Releases Packages Wiki Activity

Be more intelligent about limiting the index size

Browse source
This commit is contained in:
Kijin Sung 2016-01-11 13:50:39 +09:00
parent 4416c39fb2
commit 43033763f0
1 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

24
classes/db/DBMysql.class.php
View file

@ -593,6 +593,7 @@ class DBMysql extends DB
$default = $column->attrs->default; $default = $column->attrs->default;
$auto_increment = $column->attrs->auto_increment; $auto_increment = $column->attrs->auto_increment;
$column_charset = ''; $column_charset = '';
$index_size_limit = '';
// MySQL only supports 767 bytes for indexed columns. // MySQL only supports 767 bytes for indexed columns.
// This is 191 characters in utf8mb4 and 255 characters in utf8. // This is 191 characters in utf8mb4 and 255 characters in utf8.
@ -602,13 +603,16 @@ class DBMysql extends DB
} }
elseif(($primary_key || $unique || $index) && stripos($type, 'char') !== false) elseif(($primary_key || $unique || $index) && stripos($type, 'char') !== false)
{ {
if($size > 191 && $this->charset === 'utf8mb4') if($size > 255 || ($size > 191 && $this->charset === 'utf8mb4'))
{ {
$column_charset = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci'; if($primary_key || $unique)
{
$size = ($this->charset === 'utf8mb4') ? 191 : 255;
} }
if($size > 255) else
{ {
$size = 255; $index_size_limit = '(' . (($this->charset === 'utf8mb4') ? 191 : 255) . ')';
}
} }
} }
@ -624,15 +628,15 @@ class DBMysql extends DB
if($primary_key) if($primary_key)
{ {
$primary_list[] = $name; $primary_list[] = "`$name`";
} }
else if($unique) else if($unique)
{ {
$unique_list[$unique][] = $name; $unique_list[$unique][] = "`$name`" . $index_size_limit;
} }
else if($index) else if($index)
{ {
$index_list[$index][] = $name; $index_list[$index][] = "`$name`" . $index_size_limit;
} }
} }
@ -641,20 +645,20 @@ class DBMysql extends DB
// Process indexes // Process indexes
if(count($primary_list)) if(count($primary_list))
{ {
$column_schema[] = sprintf("PRIMARY KEY (%s)", '`' . implode($primary_list, '`, `') . '`'); $column_schema[] = sprintf("PRIMARY KEY (%s)", implode($primary_list, ', '));
} }
if(count($unique_list)) if(count($unique_list))
{ {
foreach($unique_list as $key => $val) foreach($unique_list as $key => $val)
{ {
$column_schema[] = sprintf("UNIQUE %s (%s)", $key, '`' . implode($val, '`, `') . '`'); $column_schema[] = sprintf("UNIQUE %s (%s)", $key, implode($val, ', '));
} }
} }
if(count($index_list)) if(count($index_list))
{ {
foreach($index_list as $key => $val) foreach($index_list as $key => $val)
{ {
$column_schema[] = sprintf("INDEX %s (%s)", $key, '`' . implode($val, '`, `') . '`'); $column_schema[] = sprintf("INDEX %s (%s)", $key, implode($val, ', '));
} }
} }