Move trigger to moduleObject.proc.after for better consistency

This commit is contained in:
Kijin Sung 2016-03-16 14:48:54 +09:00
parent 4b2bced0eb
commit 488704acf0
2 changed files with 23 additions and 1 deletions

View file

@ -9,9 +9,12 @@
class communication extends ModuleObject
{
private $triggers = array(
array('moduleHandler.init', 'communication', 'controller', 'triggerModuleHandlerBefore', 'before'),
array('moduleObject.proc', 'communication', 'controller', 'triggerModuleProcAfter', 'after'),
array('member.getMemberMenu', 'communication', 'controller', 'triggerMemberMenu', 'before')
);
private $delete_triggers = array(
array('moduleHandler.init', 'communication', 'controller', 'triggerModuleHandlerBefore', 'before'),
);
/**
* Implement if additional tasks are necessary when installing
@ -47,6 +50,13 @@ class communication extends ModuleObject
return TRUE;
}
}
foreach($this->delete_triggers as $trigger)
{
if($oModuleModel->getTrigger($trigger[0], $trigger[1], $trigger[2], $trigger[3], $trigger[4]))
{
return TRUE;
}
}
if(!is_dir("./files/member_extra_info/new_message_flags"))
{
@ -72,6 +82,13 @@ class communication extends ModuleObject
$oModuleController->insertTrigger($trigger[0], $trigger[1], $trigger[2], $trigger[3], $trigger[4]);
}
}
foreach($this->delete_triggers as $trigger)
{
if($oModuleModel->getTrigger($trigger[0], $trigger[1], $trigger[2], $trigger[3], $trigger[4]))
{
$oModuleController->deleteTrigger($trigger[0], $trigger[1], $trigger[2], $trigger[3], $trigger[4]);
}
}
if(!is_dir("./files/member_extra_info/new_message_flags"))
{

View file

@ -798,6 +798,11 @@ class communicationController extends communication
}
function triggerModuleHandlerBefore($obj)
{
return $this->triggerModuleProcAfter($obj);
}
function triggerModuleProcAfter($obj)
{
if(!Context::get('is_logged') || $obj->module == 'member')
{