Hide extra vars with no value #2486

modules/board/m.skins/default/read.html

@@ -22,9 +22,11 @@
 			{@ $_extra_vars = $oDocument->getExtraVars(); }
 			<dl class="xv">
 			<!--@foreach($_extra_vars as $key => $val)-->
+				<!--@if($val->hasValue())-->
 					<dt>{$val->name}</dt>
 					<dd>{$val->getValueHTML()}</dd>
 				<!--@end-->
+			<!--@end-->
 			</dl>
 		<!--@end-->
 		{$oDocument->getContent(false)}

modules/board/skins/default/_read.html

@@ -22,7 +22,7 @@
 	<!-- Extra Output -->
 	<div class="exOut" cond="$oDocument->isExtraVarsExists() && $oDocument->isAccessible()">
 		<table border="1" cellspacing="0" summary="Extra Form Output">
-			<tr loop="$oDocument->getExtraVars() => $key,$val">
+			<tr loop="$oDocument->getExtraVars() => $key,$val" cond="$val->hasValue()">
 				<th scope="row">{$val->name}</th>
 				<td>{$val->getValueHTML()}&nbsp;</td>
 			</tr>

modules/board/skins/xedition/_read.html

@@ -26,7 +26,7 @@
 	<!-- Extra Output -->
 	<div class="exOut" cond="$oDocument->isExtraVarsExists() && $oDocument->isAccessible()">
 		<table border="1" cellspacing="0" summary="Extra Form Output">
-			<tr loop="$oDocument->getExtraVars() => $key,$val">
+			<tr loop="$oDocument->getExtraVars() => $key,$val" cond="$val->hasValue()">
 				<th scope="row">{$val->name}</th>
 				<td>{$val->getValueHTML()}&nbsp;</td>
 			</tr>

modules/extravar/models/Value.php

@@ -121,6 +121,24 @@ class Value
 		$this->value = $value;
 	}
 
+	/**
+	 * Check if this extra variable has a value.
+	 *
+	 * @return bool
+	 */
+	public function hasValue(): bool
+	{
+		$value = self::_getTypeValue($this->type, $this->value);
+		if ($value === null || $value === '' || (is_array($value) && !count($value)))
+		{
+			return false;
+		}
+		else
+		{
+			return true;
+		}
+	}
+
 	/**
 	 * Get the raw value.
 	 *