From 4dca555392098cc22cffca8bc850be22fdaea646 Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Wed, 10 Oct 2018 15:58:45 +0900 Subject: [PATCH] Don't cache member info if DB query fails xpressengine/xe-core#2308 --- modules/member/member.model.php | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/modules/member/member.model.php b/modules/member/member.model.php index 6799b4c44..a1d049108 100644 --- a/modules/member/member.model.php +++ b/modules/member/member.model.php @@ -330,7 +330,10 @@ class memberModel extends member } $member_info = $this->arrangeMemberInfo($output->data, $site_srl); - Rhymix\Framework\Cache::set($cache_key, $member_info); + if($output->toBool()) + { + Rhymix\Framework\Cache::set($cache_key, $member_info); + } } } @@ -492,7 +495,10 @@ class memberModel extends member $group_list[$default_group->group_srl] = $default_group->title; } //insert in cache - Rhymix\Framework\Cache::set($cache_key, $group_list, 0, true); + if ($output->toBool()) + { + Rhymix\Framework\Cache::set($cache_key, $group_list, 0, true); + } } if(!$group_list) return array(); @@ -539,7 +545,10 @@ class memberModel extends member $args->site_srl = $site_srl; $output = executeQuery('member.getDefaultGroup', $args); $default_group = $output->data; - Rhymix\Framework\Cache::set($cache_key, $default_group, 0, true); + if($output->toBool()) + { + Rhymix\Framework\Cache::set($cache_key, $default_group, 0, true); + } } return $default_group; @@ -590,7 +599,10 @@ class memberModel extends member $args->order_type = 'asc'; $output = executeQueryArray('member.getGroups', $args); $group_list = $output->data; - Rhymix\Framework\Cache::set("member:member_groups:site:$site_srl", $group_list, 0, true); + if($output->toBool()) + { + Rhymix\Framework\Cache::set("member:member_groups:site:$site_srl", $group_list, 0, true); + } } if(!$group_list)