fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-09 12:02:24 +09:00
Code Issues Projects Releases Packages Wiki Activity

Prevent race condition on thumbnail generation

Browse source
This commit is contained in:
Kijin Sung 2015-08-17 10:49:12 +09:00
parent 94d43c2b76
commit 4e6d768dab
2 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
modules/comment/comment.item.php
View file

@ -584,6 +584,9 @@ class commentItem extends Object
} }
} }
// Prevent race condition
FileHandler::writeFile($thumbnail_file, '', 'w');
// Target file // Target file
$source_file = NULL; $source_file = NULL;
$is_tmp_file = FALSE; $is_tmp_file = FALSE;
@ -685,12 +688,6 @@ class commentItem extends Object
return $thumbnail_url; return $thumbnail_url;
} }
// create an empty file not to attempt to generate the thumbnail afterwards
else
{
FileHandler::writeFile($thumbnail_file, '', 'w');
}
return; return;
} }

5
modules/document/document.item.php
View file

@ -829,6 +829,9 @@ class documentItem extends Object
else return $thumbnail_url; else return $thumbnail_url;
} }
// Prevent race condition
FileHandler::writeFile($thumbnail_file, '', 'w');
// Target File // Target File
$source_file = null; $source_file = null;
$is_tmp_file = false; $is_tmp_file = false;
@ -906,8 +909,6 @@ class documentItem extends Object
if($is_tmp_file) FileHandler::removeFile($source_file); if($is_tmp_file) FileHandler::removeFile($source_file);
// Return its path if a thumbnail is successfully genetated // Return its path if a thumbnail is successfully genetated
if($output) return $thumbnail_url; if($output) return $thumbnail_url;
// Create an empty file not to re-generate the thumbnail
else FileHandler::writeFile($thumbnail_file, '','w');
return; return;
} }