From 54f0346a50abd5deda601d23aea93187779381d5 Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Thu, 6 Sep 2018 00:22:06 +0900 Subject: [PATCH] Update recaptcha addon to throw exceptions on error --- addons/recaptcha/recaptcha.class.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/recaptcha/recaptcha.class.php b/addons/recaptcha/recaptcha.class.php index dbf2bf86c..11177627b 100644 --- a/addons/recaptcha/recaptcha.class.php +++ b/addons/recaptcha/recaptcha.class.php @@ -18,7 +18,7 @@ class reCAPTCHA $response = Context::get('g-recaptcha-response'); if (!$response) { - return new BaseObject(-1, 'recaptcha.msg_recaptcha_invalid_response'); + throw new Rhymix\Framework\Exception('recaptcha.msg_recaptcha_invalid_response'); } try @@ -31,17 +31,17 @@ class reCAPTCHA } catch (\Requests_Exception $e) { - return new BaseObject(-1, 'recaptcha.msg_recaptcha_connection_error'); + throw new Rhymix\Framework\Exception('recaptcha.msg_recaptcha_connection_error'); } $verify = @json_decode($verify_request->body, true); if ($verify && isset($verify['error-codes']) && in_array('invalid-input-response', $verify['error-codes'])) { - return new BaseObject(-1, 'recaptcha.msg_recaptcha_invalid_response'); + throw new Rhymix\Framework\Exception('recaptcha.msg_recaptcha_invalid_response'); } elseif (!$verify || !$verify['success'] || (isset($verify['error-codes']) && $verify['error-codes'])) { - return new BaseObject(-1, 'recaptcha.msg_recaptcha_server_error'); + throw new Rhymix\Framework\Exception('recaptcha.msg_recaptcha_server_error'); } else {