fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-10 20:44:28 +09:00
Code Issues Projects Releases Packages Wiki Activity

Improve referer checks in Session::checkSSO()

Browse source
This commit is contained in:
Kijin Sung 2017-03-04 22:15:46 +09:00
parent af7309b807
commit 5bd5044126
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
common/framework/session.php
View file

@ -313,6 +313,11 @@ class Session
\Context::displayErrorPage('SSO Error', 'Invalid SSO Request', 400); \Context::displayErrorPage('SSO Error', 'Invalid SSO Request', 400);
exit; exit;
} }
if (!URL::isInternalUrl($sso_request) || !Security::checkCSRF())
{
\Context::displayErrorPage('SSO Error', 'Invalid SSO Request', 400);
exit;
}
// Encrypt the session ID. // Encrypt the session ID.
self::start(true); self::start(true);
@ -336,7 +341,7 @@ class Session
} }
// Check that the response was given by the default site (to prevent session fixation CSRF). // Check that the response was given by the default site (to prevent session fixation CSRF).
if(isset($_SERVER['HTTP_REFERER']) && strpos($_SERVER['HTTP_REFERER'], $default_url) !== 0) if(isset($_SERVER['HTTP_REFERER']) && strpos(URL::decodeIdna($_SERVER['HTTP_REFERER']), $default_url) !== 0)
{ {
\Context::displayErrorPage('SSO Error', 'Invalid SSO Response', 400); \Context::displayErrorPage('SSO Error', 'Invalid SSO Response', 400);
exit; exit;