From 711109672fff012eb527a090ed3cbb0b78540849 Mon Sep 17 00:00:00 2001
From: ovclas <ovclas@gmail.com>
Date: Thu, 29 Mar 2012 05:56:33 +0000
Subject: [PATCH] issue 1793 check null parameter in method. and 'notnull'
 attribute add to query

git-svn-id: http://xe-core.googlecode.com/svn/branches/1.5.0@10494 201d5d3c-b55e-5fd7-737f-ddc643e51545
---
 modules/document/document.controller.php      | 22 ++++++++++++-------
 .../updateDocumentExtraKeyIdxOrder.xml        |  2 +-
 .../updateDocumentExtraVarIdxOrder.xml        |  2 +-
 3 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/modules/document/document.controller.php b/modules/document/document.controller.php
index 2e12a9ad8..7cfb853c8 100644
--- a/modules/document/document.controller.php
+++ b/modules/document/document.controller.php
@@ -722,11 +722,14 @@ class documentController extends document {
 			return $output;
 		}
 
-		$output = $oDB->executeQuery('document.updateDocumentExtraKeyIdxOrder', $obj);
-		if(!$output->toBool())
+		if($var_idx != NULL)
 		{
-			$oDB->rollback();
-			return $output;
+			$output = $oDB->executeQuery('document.updateDocumentExtraKeyIdxOrder', $obj);
+			if(!$output->toBool())
+			{
+				$oDB->rollback();
+				return $output;
+			}
 		}
 
 		$output =  executeQuery('document.deleteDocumentExtraVars', $obj);
@@ -736,11 +739,14 @@ class documentController extends document {
 			return $output;
 		}
 
-		$output = $oDB->executeQuery('document.updateDocumentExtraVarIdxOrder', $obj);
-		if(!$output->toBool())
+		if($var_idx != NULL)
 		{
-			$oDB->rollback();
-			return $output;
+			$output = $oDB->executeQuery('document.updateDocumentExtraVarIdxOrder', $obj);
+			if(!$output->toBool())
+			{
+				$oDB->rollback();
+				return $output;
+			}
 		}
 
 		$oDB->commit();
diff --git a/modules/document/queries/updateDocumentExtraKeyIdxOrder.xml b/modules/document/queries/updateDocumentExtraKeyIdxOrder.xml
index 16aaf9fca..101e55eaa 100644
--- a/modules/document/queries/updateDocumentExtraKeyIdxOrder.xml
+++ b/modules/document/queries/updateDocumentExtraKeyIdxOrder.xml
@@ -7,6 +7,6 @@
 	</columns>
 	<conditions>
 		<condition operation="equal" column="module_srl" var="module_srl" filter="number" notnull="notnull" />
-		<condition operation="excess" column="var_idx" var="var_idx" filter="number" pipe="and" />
+		<condition operation="excess" column="var_idx" var="var_idx" filter="number" notnull="notnull" pipe="and" />
 	</conditions>
 </query>
diff --git a/modules/document/queries/updateDocumentExtraVarIdxOrder.xml b/modules/document/queries/updateDocumentExtraVarIdxOrder.xml
index a6ad2101b..83887df85 100644
--- a/modules/document/queries/updateDocumentExtraVarIdxOrder.xml
+++ b/modules/document/queries/updateDocumentExtraVarIdxOrder.xml
@@ -7,6 +7,6 @@
 	</columns>
 	<conditions>
 		<condition operation="equal" column="module_srl" var="module_srl" filter="number" notnull="notnull" />
-		<condition operation="excess" column="var_idx" var="var_idx" filter="number" pipe="and" />
+		<condition operation="excess" column="var_idx" var="var_idx" filter="number" notnull="notnull" pipe="and" />
 	</conditions>
 </query>