Remove unnecessary use of BaseObject

- 트리거 등 반환값이 필요하지 않은 곳에서 new BaseObject()를 반환하는 것 삭제
- 모듈 설치, 업데이트 후 무의미한 new BaseObject()를 반환하는 것 삭제
- 사용자에게 에러 메시지를 돌려주는 용도로 new BaseObject(-1, '에러메시지')를
  사용하는 경우는 대부분 $this->setError()로 변경함. 언어 변환과 sprintf()
  처리까지 한 번에 이루어지므로 이쪽이 더 편리함.

modules/editor/editor.admin.controller.php

@@ -251,7 +251,7 @@ class editorAdminController extends editor
 		// Check if the component exists
 		if(!$site_srl) $output = executeQuery('editor.isComponentInserted', $args);
 		else $output = executeQuery('editor.isSiteComponentInserted', $args);
-		if($output->data->count) return new BaseObject(-1, 'msg_component_is_not_founded');
+		if($output->data->count) return $this->setError('msg_component_is_not_founded');
 		// Inert a component
 		$args->list_order = getNextSequence();
 		if(!$site_srl) $output = executeQuery('editor.insertComponent', $args);

modules/editor/editor.class.php

@@ -83,8 +83,6 @@ class editor extends ModuleObject
 		$oModuleController->insertTrigger('module.dispAdditionSetup', 'editor', 'view', 'triggerDispEditorAdditionSetup', 'before');
 		// 2009. 04. 14 Add a trigger from compiled codes of the editor component
 		$oModuleController->insertTrigger('display', 'editor', 'controller', 'triggerEditorComponentCompile', 'before');
-
-		return new BaseObject();
 	}
 
 	/**
@@ -151,8 +149,6 @@ class editor extends ModuleObject
 		{
 			$oModuleController->insertTrigger('module.procModuleAdminCopyModule', 'editor', 'controller', 'triggerCopyModule', 'after');
 		}
-
-		return new BaseObject(0, 'success_updated');
 	}
 
 	/**

modules/editor/editor.controller.php

@@ -47,18 +47,18 @@ class editorController extends editor
 	{
 		$component = Context::get('component');
 		$method = Context::get('method');
-		if(!$component) return new BaseObject(-1, sprintf(lang('msg_component_is_not_founded'), $component));
+		if(!$component) return $this->setError('msg_component_is_not_founded', $component);
 
 		$oEditorModel = getModel('editor');
 		$oComponent = &$oEditorModel->getComponentObject($component);
 		if(!$oComponent->toBool()) return $oComponent;
 
-		if(!method_exists($oComponent, $method)) return new BaseObject(-1, sprintf(lang('msg_component_is_not_founded'), $component));
+		if(!method_exists($oComponent, $method)) return $this->setError('msg_component_is_not_founded', $component);
 
 		//$output = call_user_method($method, $oComponent);
 		//$output = call_user_func(array($oComponent, $method));
 		if(method_exists($oComponent, $method)) $output = $oComponent->{$method}();
-		else return new BaseObject(-1,sprintf('%s method is not exists', $method));
+		else return $this->setError('%s method is not exists', $method);
 
 		if($output instanceof Object && !$output->toBool()) return $output;
 
@@ -93,13 +93,13 @@ class editorController extends editor
 			$module_info = $oModuleModel->getModuleInfoByModuleSrl($srl);
 			if (!$module_info->module_srl)
 			{
-				return new BaseObject(-1, 'msg_invalid_request');
+				return $this->setError('msg_invalid_request');
 			}
 			
 			$module_grant = $oModuleModel->getGrant($module_info, $logged_info);
 			if (!$module_grant->manager)
 			{
-				return new BaseObject(-1, 'msg_not_permitted');
+				return $this->setError('msg_not_permitted');
 			}
 			
 			$module_srl[] = $srl;
@@ -171,7 +171,7 @@ class editorController extends editor
 	 */
 	function triggerEditorComponentCompile(&$content)
 	{
-		if(Context::getResponseMethod()!='HTML') return new BaseObject();
+		if(Context::getResponseMethod() !== 'HTML') return;
 
 		$module_info = Context::get('module_info');
 		$module_srl = $module_info->module_srl;
@@ -253,7 +253,6 @@ class editorController extends editor
 		}
 
 		$content = $this->transComponent($content);
-		return new BaseObject();
 	}
 
 	/**
@@ -350,7 +349,6 @@ class editorController extends editor
 	function triggerDeleteSavedDoc(&$obj)
 	{
 		$this->deleteSavedDoc(false);
-		return new BaseObject();
 	}
 
 	/**

modules/editor/editor.model.php

@@ -466,11 +466,11 @@ class editorModel extends editor
 			// Create an object of the component and execute
 			$class_path = sprintf('%scomponents/%s/', $this->module_path, $component);
 			$class_file = sprintf('%s%s.class.php', $class_path, $component);
-			if(!file_exists($class_file)) return new BaseObject(-1, sprintf(lang('msg_component_is_not_founded'), $component));
+			if(!file_exists($class_file)) return $this->setError('msg_component_is_not_founded', $component);
 			// Create an object after loading the class file
 			require_once($class_file);
 			$oComponent = new $component($editor_sequence, $class_path);
-			if(!$oComponent) return new BaseObject(-1, sprintf(lang('msg_component_is_not_founded'), $component));
+			if(!$oComponent) return $this->setError('msg_component_is_not_founded', $component);
 			// Add configuration information
 			$component_info = $this->getComponent($component, $site_srl);
 			$oComponent->setInfo($component_info);