fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-05-10 20:44:28 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix #1999 missing rollback on query error during updateVotedCount

Browse source
This commit is contained in:
Kijin Sung 2022-10-11 01:09:05 +09:00
parent c2bf7d65ce
commit 9bc69abe0b
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
modules/document/document.controller.php
View file

@ -1793,7 +1793,11 @@ class documentController extends document
$args->voted_count = $trigger_obj->after_point; $args->voted_count = $trigger_obj->after_point;
$output = executeQuery('document.updateVotedCount', $args); $output = executeQuery('document.updateVotedCount', $args);
} }
if(!$output->toBool()) return $output; if(!$output->toBool())
{
$oDB->rollback();
return $output;
}
// Leave in the session information // Leave in the session information
$_SESSION['voted_document'][$document_srl] = $trigger_obj->point; $_SESSION['voted_document'][$document_srl] = $trigger_obj->point;
@ -1801,7 +1805,11 @@ class documentController extends document
// Leave logs // Leave logs
$args->point = $trigger_obj->point; $args->point = $trigger_obj->point;
$output = executeQuery('document.insertDocumentVotedLog', $args); $output = executeQuery('document.insertDocumentVotedLog', $args);
if(!$output->toBool()) return $output; if(!$output->toBool())
{
$oDB->rollback();
return $output;
}
// Call a trigger (after) // Call a trigger (after)
ModuleHandler::triggerCall('document.updateVotedCount', 'after', $trigger_obj); ModuleHandler::triggerCall('document.updateVotedCount', 'after', $trigger_obj);