From a107e86dc65b4fe6a6913debb23f09c5af9a8b32 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Thu, 28 Apr 2016 13:03:23 +0900
Subject: [PATCH] Reduce risk of accidental disclosure of member_srl and other
 personal info

---
 modules/board/skins/default/_comment.html  | 6 +++---
 modules/board/skins/default/_read.html     | 6 +++---
 modules/board/skins/xedition/_comment.html | 6 +++---
 modules/board/skins/xedition/_read.html    | 6 +++---
 modules/comment/comment.item.php           | 4 ++--
 modules/document/document.item.php         | 4 ++--
 6 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/modules/board/skins/default/_comment.html b/modules/board/skins/default/_comment.html
index 99c6983ac..ada266cb0 100644
--- a/modules/board/skins/default/_comment.html
+++ b/modules/board/skins/default/_comment.html
@@ -9,9 +9,9 @@
 				<img cond="$comment->getProfileImage()" src="{$comment->getProfileImage()}" alt="Profile" class="profile" />
 				<span cond="!$comment->getProfileImage()" class="profile"></span>
 				<h3 class="author">
-					<a cond="!$comment->member_srl && $comment->homepage" href="{$comment->getHomepageUrl()}">{$comment->getNickName()}</a>
-					<strong cond="!$comment->member_srl && !$comment->homepage">{$comment->getNickName()}</strong>
-					<a cond="$comment->member_srl" href="#popup_menu_area" class="member_{$comment->member_srl}" onclick="return false">{$comment->getNickName()}</a>
+					<a cond="$comment->member_srl <= 0 && $comment->homepage" href="{$comment->getHomepageUrl()}">{$comment->getNickName()}</a>
+					<strong cond="$comment->member_srl <= 0 && !$comment->homepage">{$comment->getNickName()}</strong>
+					<a cond="$comment->member_srl > 0" href="#popup_menu_area" class="member_{$comment->member_srl}" onclick="return false">{$comment->getNickName()}</a>
 				</h3>
 				<p class="time">{$comment->getRegdate('Y.m.d H:i')}</p>
 			</div>
diff --git a/modules/board/skins/default/_read.html b/modules/board/skins/default/_read.html
index 280c3461e..f99b11ab1 100644
--- a/modules/board/skins/default/_read.html
+++ b/modules/board/skins/default/_read.html
@@ -9,9 +9,9 @@
 			{$oDocument->getRegdate('Y.m.d H:i')}
 		</p>
 		<p class="meta">
-			<a cond="$module_info->display_author!='N' && !$oDocument->getMemberSrl() && $oDocument->isExistsHomepage()" href="{$oDocument->getHomepageUrl()}" onclick="window.open(this.href);return false;" class="author">{$oDocument->getNickName()}</a>
-			<block cond="$module_info->display_author!='N' && !$oDocument->getMemberSrl() && !$oDocument->isExistsHomepage()">{$oDocument->getNickName()}</block>
-			<a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl()" href="#popup_menu_area" class="member_{$oDocument->get('member_srl')} author" onclick="return false">{$oDocument->getNickName()}</a>
+			<a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() <= 0 && $oDocument->isExistsHomepage()" href="{$oDocument->getHomepageUrl()}" onclick="window.open(this.href);return false;" class="author">{$oDocument->getNickName()}</a>
+			<block cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() <= 0 && !$oDocument->isExistsHomepage()">{$oDocument->getNickName()}</block>
+			<a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() > 0" href="#popup_menu_area" class="member_{$oDocument->get('member_srl')} author" onclick="return false">{$oDocument->getNickName()}</a>
 			<span class="sum">
 				<span class="read">{$lang->readed_count}:{$oDocument->get('readed_count')}</span>
 				<span class="vote" cond="$oDocument->get('voted_count')!=0">{$lang->cmd_vote}:{$oDocument->get('voted_count')}</span>
diff --git a/modules/board/skins/xedition/_comment.html b/modules/board/skins/xedition/_comment.html
index fabb798c7..e2fffcbbd 100644
--- a/modules/board/skins/xedition/_comment.html
+++ b/modules/board/skins/xedition/_comment.html
@@ -9,9 +9,9 @@
 				<img cond="$comment->getProfileImage()" src="{$comment->getProfileImage()}" alt="Profile" class="profile" />
 				<span cond="!$comment->getProfileImage()" class="profile"></span>
 				<h3 class="author">
-					<a cond="!$comment->member_srl && $comment->homepage" href="{$comment->getHomepageUrl()}">{$comment->getNickName()}</a>
-					<strong cond="!$comment->member_srl && !$comment->homepage">{$comment->getNickName()}</strong>
-					<a cond="$comment->member_srl" href="#popup_menu_area" class="member_{$comment->member_srl}" onclick="return false">{$comment->getNickName()}</a>
+					<a cond="$comment->member_srl <= 0 && $comment->homepage" href="{$comment->getHomepageUrl()}">{$comment->getNickName()}</a>
+					<strong cond="$comment->member_srl <= 0 && !$comment->homepage">{$comment->getNickName()}</strong>
+					<a cond="$comment->member_srl > 0" href="#popup_menu_area" class="member_{$comment->member_srl}" onclick="return false">{$comment->getNickName()}</a>
 				</h3>
 				<p class="time">{$comment->getRegdate('Y.m.d H:i')}</p>
 			</div>
diff --git a/modules/board/skins/xedition/_read.html b/modules/board/skins/xedition/_read.html
index f0102cb25..8558205ec 100644
--- a/modules/board/skins/xedition/_read.html
+++ b/modules/board/skins/xedition/_read.html
@@ -7,9 +7,9 @@
 		</h1>
 		<p class="meta">
 			<span class="author">
-				<i class="xi-user"></i><a cond="$module_info->display_author!='N' && !$oDocument->getMemberSrl() && $oDocument->isExistsHomepage()" href="{$oDocument->getHomepageUrl()}" onclick="window.open(this.href);return false;" class="author">{$oDocument->getNickName()}</a>
-				<block cond="$module_info->display_author!='N' && !$oDocument->getMemberSrl() && !$oDocument->isExistsHomepage()">{$oDocument->getNickName()}</block>
-				<a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl()" href="#popup_menu_area" class="member_{$oDocument->get('member_srl')} author" onclick="return false">{$oDocument->getNickName()}</a>
+				<i class="xi-user"></i><a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() <= 0 && $oDocument->isExistsHomepage()" href="{$oDocument->getHomepageUrl()}" onclick="window.open(this.href);return false;" class="author">{$oDocument->getNickName()}</a>
+				<block cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() <= 0 && !$oDocument->isExistsHomepage()">{$oDocument->getNickName()}</block>
+				<a cond="$module_info->display_author!='N' && $oDocument->getMemberSrl() > 0" href="#popup_menu_area" class="member_{$oDocument->get('member_srl')} author" onclick="return false">{$oDocument->getNickName()}</a>
 			</span>
 			<span class="time">
 				<i class="xi-time"></i> {$oDocument->getRegdate('Y.m.d H:i')}
diff --git a/modules/comment/comment.item.php b/modules/comment/comment.item.php
index 9242cc3bd..5856a735a 100644
--- a/modules/comment/comment.item.php
+++ b/modules/comment/comment.item.php
@@ -496,7 +496,7 @@ class commentItem extends Object
 	 */
 	function getProfileImage()
 	{
-		if(!$this->isExists() || !$this->get('member_srl'))
+		if(!$this->isExists() || $this->get('member_srl') <= 0)
 		{
 			return;
 		}
@@ -517,7 +517,7 @@ class commentItem extends Object
 	function getSignature()
 	{
 		// pass if the posting not exists.
-		if(!$this->isExists() || !$this->get('member_srl'))
+		if(!$this->isExists() || $this->get('member_srl') <= 0)
 		{
 			return;
 		}
diff --git a/modules/document/document.item.php b/modules/document/document.item.php
index 63b8747e6..9b38b216a 100644
--- a/modules/document/document.item.php
+++ b/modules/document/document.item.php
@@ -1168,7 +1168,7 @@ class documentItem extends Object
 	 */
 	function getProfileImage()
 	{
-		if(!$this->isExists() || !$this->get('member_srl')) return;
+		if(!$this->isExists() || $this->get('member_srl') <= 0) return;
 		$oMemberModel = getModel('member');
 		$profile_info = $oMemberModel->getProfileImage($this->get('member_srl'));
 		if(!$profile_info) return;
@@ -1183,7 +1183,7 @@ class documentItem extends Object
 	function getSignature()
 	{
 		// Pass if a document doesn't exist
-		if(!$this->isExists() || !$this->get('member_srl')) return;
+		if(!$this->isExists() || $this->get('member_srl') <= 0) return;
 		// Get signature information
 		$oMemberModel = getModel('member');
 		$signature = $oMemberModel->getSignature($this->get('member_srl'));