fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-01-04 17:21:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix incorrect return type when HTTP::download() cannot write to target file or parent directory

Browse source
This commit is contained in:
Kijin Sung 2025-05-12 12:25:46 +09:00
parent 087f5a2265
commit a1ae74837f
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
common/framework/HTTP.php
View file

@ -91,7 +91,11 @@ class HTTP
$target_dir = dirname($target_filename); $target_dir = dirname($target_filename);
if (!Storage::isDirectory($target_dir) && !Storage::createDirectory($target_dir)) if (!Storage::isDirectory($target_dir) && !Storage::createDirectory($target_dir))
{ {
return false; return new Helpers\HTTPHelper(new Exception('Cannot create directory: ' . $target_dir));
}
if (!Storage::isWritable($target_dir) && (!Storage::exists($target_filename) || !Storage::isWritable($target_filename)))
{
return new Helpers\HTTPHelper(new Exception('No permission to write file: ' . $target_filename));
} }
// Pass to request() with appropriate settings for the filename. // Pass to request() with appropriate settings for the filename.