fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-01-03 16:51:40 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix incorrect querystring when comparing column against null value

Browse source
This commit is contained in:
Kijin Sung 2022-01-20 16:37:12 +09:00
parent 22182c4c19
commit a6f771c155
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
common/framework/parsers/dbquery/variablebase.php
View file

@ -105,12 +105,12 @@ class VariableBase
switch ($this->operation)
{
case 'equal':
$where = sprintf('%s = %s', $column, $is_expression ? $value : '?');
$where = sprintf('%s %s %s', $column, ($is_expression && $value === 'NULL') ? 'IS' : '=', $is_expression ? $value : '?');
if (!$is_expression) $params[] = $value;
break;
case 'notequal':
case 'not_equal':
$where = sprintf('%s != %s', $column, $is_expression ? $value : '?');
$where = sprintf('%s %s %s', $column, ($is_expression && $value === 'NULL') ? 'IS NOT' : '!=', $is_expression ? $value : '?');
if (!$is_expression) $params[] = $value;
break;
case 'more':

2
tests/unit/framework/parsers/DBQueryParserTest.php
View file

@ -423,7 +423,7 @@ class DBQueryParserTest extends \Codeception\TestCase\Test
$sql = $query->getQueryString('rx_', $args);
$params = $query->getQueryParams();
$this->assertEquals('UPDATE `rx_documents` SET `member_srl` = ?, `nick_name` = NULL, `voted_count` = `voted_count` + ? WHERE `document_srl` = ?', $sql);
$this->assertEquals('UPDATE `rx_documents` SET `member_srl` = ?, `nick_name` IS NULL, `voted_count` = `voted_count` + ? WHERE `document_srl` = ?', $sql);
$this->assertEquals(['456', '5', '123'], $params);
}