fanbinit/rhymix
1
0
Fork 0
mirror of https://github.com/Lastorder-DC/rhymix.git synced 2026-04-22 03:42:18 +09:00
Code Issues Projects Releases Packages Wiki Activity

Extend detection of buggy user agents that cannot handle session keys

Browse source
This commit is contained in:
Kijin Sung 2017-02-13 17:28:04 +09:00
parent 9c96dc04bc
commit a6fee16b68
1 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

22
common/framework/session.php
View file

@ -113,7 +113,7 @@ class Session
// Check whether the visitor uses Android webview.
if (!isset($_SESSION['is_webview']))
{
$_SESSION['is_webview'] = UA::getBrowserInfo()->browser === 'Android' ? true : false;
$_SESSION['is_webview'] = self::_isBuggyUserAgent();
}
// Validate the HTTP key.
@ -362,7 +362,7 @@ class Session
$_SESSION['RHYMIX']['timezone'] = DateTime::getTimezoneForCurrentUser();
$_SESSION['RHYMIX']['secret'] = Security::getRandom(32, 'alnum');
$_SESSION['RHYMIX']['tokens'] = array();
$_SESSION['is_webview'] = UA::getBrowserInfo()->browser === 'Android' ? true : false;
$_SESSION['is_webview'] = self::_isBuggyUserAgent();
$_SESSION['is_logged'] = false;
$_SESSION['is_admin'] = '';
@ -972,6 +972,24 @@ class Session
return Security::decrypt($ciphertext, $key);
}
/**
* Check if the user-agent is known to have a problem with security keys.
*
* @return bool
*/
protected static function _isBuggyUserAgent()
{
$browser = UA::getBrowserInfo();
if ($browser->browser === 'Android' || ($browser->os === 'Android' && $browser->browser === 'Chrome'))
{
return true;
}
else
{
return false;
}
}
/**
* Get session parameters.
*