Clean up dead code #2612

This commit is contained in:
Kijin Sung 2025-11-12 21:55:49 +09:00
parent 64d9982978
commit a8749f1078
2 changed files with 2 additions and 11 deletions

View file

@ -326,8 +326,6 @@ class ModuleAdminController extends Module
if(strlen($default)) if(strlen($default))
{ {
$grant->{$grant_name}[] = $default; $grant->{$grant_name}[] = $default;
continue;
// users in a particular group
} }
else else
{ {
@ -339,9 +337,7 @@ class ModuleAdminController extends Module
else $group_srls = array($group_srls); else $group_srls = array($group_srls);
$grant->{$grant_name} = $group_srls; $grant->{$grant_name} = $group_srls;
} }
continue;
} }
$grant->{$group_srls} = array(); // dead code????
} }
// Stored in the DB // Stored in the DB
@ -609,8 +605,6 @@ class ModuleAdminController extends Module
if(strlen($default)) if(strlen($default))
{ {
$grant->{$grant_name}[] = $default; $grant->{$grant_name}[] = $default;
continue;
// Users in a particular group
} }
else else
{ {
@ -625,9 +619,7 @@ class ModuleAdminController extends Module
} }
$grant->{$grant_name} = $group_srls; $grant->{$grant_name} = $group_srls;
} }
continue;
} }
$grant->{$group_srls} = array(); // dead code, too??
} }
// Stored in the DB // Stored in the DB

View file

@ -937,8 +937,8 @@ class ModuleController extends Module
} }
if(!$output->toBool()) if(!$output->toBool())
{ {
return $output;
$oDB->rollback(); $oDB->rollback();
return $output;
} }
} }
@ -1192,12 +1192,11 @@ class ModuleController extends Module
$args->module_filebox_srl = $vars->module_filebox_srl; $args->module_filebox_srl = $vars->module_filebox_srl;
$args->comment = $vars->comment; $args->comment = $vars->comment;
return executeQuery('module.updateModuleFileBox', $args); $output = executeQuery('module.updateModuleFileBox', $args);
$output->add('save_filename', $save_filename); $output->add('save_filename', $save_filename);
return $output; return $output;
} }
/** /**
* @brief Add a file into the file box * @brief Add a file into the file box
*/ */