Fix inconsistent calling of createSignupForm() in member module

This commit is contained in:
Kijin Sung 2023-04-10 22:31:24 +09:00
parent 5c5d7223ce
commit b88fe65d6e
3 changed files with 23 additions and 10 deletions

View file

@ -626,13 +626,21 @@ class MemberAdminController extends Member
$this->setRedirectUrl($returnUrl);
}
function createSignupForm($identifier)
public static function createSignupForm($config)
{
global $lang;
$oMemberModel = getModel('member');
// Maintain backward compatibility with inconsistent use of the first parameter of this method.
if (is_object($config))
{
$identifier = $config->identifier ?? 'user_id';
}
else
{
$identifier = strval($config) ?: 'user_id';
$config = new \stdClass;
}
// Get join form list which is additionally set
$extendItems = $oMemberModel->getJoinFormList();
$extendItems = MemberModel::getJoinFormList();
$items = array('user_id', 'email_address', 'phone_number', 'password', 'user_name', 'nick_name', 'homepage', 'blog', 'birthday', 'signature', 'profile_image', 'image_name', 'image_mark');
$mustRequireds = array('email_address', 'nick_name', 'password');
@ -642,7 +650,6 @@ class MemberAdminController extends Member
foreach($items as $key)
{
unset($signupItem);
$signupItem = new stdClass;
$signupItem->isDefaultForm = true;
$signupItem->name = $key;