From d02ea160c1d3403393a5ee63ee6da25fc693af3a Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Sun, 5 Nov 2023 13:30:55 +0900 Subject: [PATCH] Fix undefined variable in getThumbnail() --- modules/comment/comment.item.php | 8 ++++++-- modules/document/document.item.php | 4 ++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/modules/comment/comment.item.php b/modules/comment/comment.item.php index 6d242678f..cee1bb7f3 100644 --- a/modules/comment/comment.item.php +++ b/modules/comment/comment.item.php @@ -901,7 +901,11 @@ class CommentItem extends BaseObject if($source_file) { - $output = FileHandler::createImageFile($source_file, $thumbnail_file, $trigger_obj->width, $trigger_obj->height, $trigger_obj->image_type, $trigger_obj->type, $trigger_obj->quality); + $output_file = FileHandler::createImageFile($source_file, $thumbnail_file, $trigger_obj->width, $trigger_obj->height, $trigger_obj->image_type, $trigger_obj->type, $trigger_obj->quality); + } + else + { + $output_file = false; } // Remove source file if it was temporary @@ -914,7 +918,7 @@ class CommentItem extends BaseObject FileHandler::removeFile($thumbnail_lockfile); // Return the thumbnail path if it was successfully generated - if($output) + if($output_file) { return $thumbnail_url . '?' . date('YmdHis'); } diff --git a/modules/document/document.item.php b/modules/document/document.item.php index 4b4524158..29d750311 100644 --- a/modules/document/document.item.php +++ b/modules/document/document.item.php @@ -1268,6 +1268,10 @@ class DocumentItem extends BaseObject { $output_file = FileHandler::createImageFile($source_file, $thumbnail_file, $trigger_obj->width, $trigger_obj->height, $trigger_obj->image_type, $trigger_obj->type, $trigger_obj->quality); } + else + { + $output_file = false; + } // Remove source file if it was temporary if($is_tmp_file)