From 5b530792e5724e109db131a482ddc04a8b3b9aa1 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Wed, 24 Apr 2024 22:45:36 +0900
Subject: [PATCH 1/8] Initial implementation of auto upload on paste or drop

---
 .../ckeditor/plugins/rx_upload/plugin.js      | 116 ++++++++++++++++++
 modules/editor/skins/ckeditor/editor.html     |   2 +-
 2 files changed, 117 insertions(+), 1 deletion(-)
 create mode 100644 common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
new file mode 100644
index 000000000..a36b27000
--- /dev/null
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -0,0 +1,116 @@
+/**
+ * Upload plugin for Rhymix
+ */
+CKEDITOR.plugins.add('rx_upload', {
+	init: function(editor) {
+
+		/**
+		 * The main event handler for paste and drop.
+		 */
+		editor.on('paste', function(event) {
+
+			// Check if the pasted data contains any files.
+			const method = event.data.method;
+			const dataTransfer = event.data.dataTransfer;
+			const files_count = dataTransfer.getFilesCount();
+			if (!files_count) {
+				return;
+			}
+
+			// Prevent the default plugin from touching these files.
+			event.stop();
+
+			// Read and upload each file.
+			for (let i = 0; i < files_count; i++) {
+				uploadFile(dataTransfer.getFile(i));
+			}
+		});
+
+		/**
+		 * Upload function.
+		 */
+		const uploadFile = function(file) {
+
+			// Get the editor sequence.
+			const editor_container = $(editor.container.$).parents('.rx_ckeditor');
+			const upload_container = editor_container.next('.xefu-container');
+			const editor_sequence = editor_container.data('editorSequence');
+
+			// Generate the form data.
+			const form = new FormData();
+			form.append('mid', window.editor_mid ? window.editor_mid : window.current_mid);
+			form.append('act', 'procFileUpload');
+			form.append('editor_sequence', editor_sequence);
+			form.append('Filedata', file);
+
+			// Upload!
+			$.ajax({
+				url: window.request_uri,
+				type: 'POST',
+				contentType: false,
+				processData: false,
+				cache: false,
+				data: form,
+				dataType: 'json',
+				success: function(data) {
+					insertFile(upload_container, data);
+					reloadFileList(upload_container, data);
+				},
+				error: function(jqXHR) {
+					alert('Upload error: ' + jqXHR.responseText);
+				}
+			});
+		};
+
+		/**
+		 * Insert file into editor.
+		 */
+		const insertFile = function(container, data) {
+			if (data.error != 0) {
+				alert(data.message);
+				return;
+			}
+
+			let temp_code = '';
+			if(/\.(gif|jpe?g|png|webp)$/i.test(data.source_filename)) {
+				temp_code += '<img src="' + data.download_url + '" alt="' + data.source_filename + '" editor_component="image_link" data-file-srl="' + data.file_srl + '" />';
+			}
+			else if(/\.(mp3|wav|ogg|flac|aac)$/i.test(data.source_filename)) {
+				temp_code += '<audio src="' + data.download_url + '" controls data-file-srl="' + data.file_srl + '" />';
+			}
+			else if(/\.(mp4|webm|ogv)$/i.test(data.source_filename)) {
+				if(data.original_type === 'image/gif') {
+					temp_code += '<video src="' + data.download_url + '" autoplay loop muted playsinline data-file-srl="' + data.file_srl + '" />';
+				} else if (data.download_url.match(/\b(?:procFileDownload\b|files\/download\/)/)) {
+					if (!data.download_url.match(/^\//)) {
+						data.download_url = XE.URI(default_url).pathname() + data.download_url;
+					}
+					temp_code += '<video src="' + data.download_url + '" controls preload="none" data-file-srl="' + data.file_srl + '" />';
+				} else {
+					temp_code += '<video src="' + data.download_url + '" controls data-file-srl="' + data.file_srl + '" />';
+				}
+				if(data.thumbnail_filename) {
+					temp_code = temp_code.replace('controls', 'poster="' + data.thumbnail_filename.replace(/^.\//, XE.URI(default_url).pathname()) + '" controls');
+				}
+			}
+			else {
+				temp_code += '<a href="' + data.download_url + '" data-file-srl="' + data.file_srl + '">' + data.source_filename + "</a>\n";
+			}
+
+			if(temp_code !== '') {
+				temp_code = "<p>" + temp_code + "</p>\n";
+			}
+
+			editor.insertHtml(temp_code, 'unfiltered_html');
+		};
+
+		/**
+		 * Reload the file list.
+		 */
+		const reloadFileList = function(container, data) {
+			container.data('editorStatus', data);
+			container.data('instance').loadFilelist(container, true);
+		};
+
+	}
+});
diff --git a/modules/editor/skins/ckeditor/editor.html b/modules/editor/skins/ckeditor/editor.html
index 4f4a694fe..b6d70cfcd 100644
--- a/modules/editor/skins/ckeditor/editor.html
+++ b/modules/editor/skins/ckeditor/editor.html
@@ -128,7 +128,6 @@
 	            fontSize_sizes: font_sizes,
 				toolbarCanCollapse: true,
 				allowedContent: true,
-				clipboard_handleImages: false,
 				startupFocus: {json_encode($editor_focus)},
 				language: "{str_replace('jp','ja',$lang_type)}",
 				iframe_attributes: {},
@@ -177,6 +176,7 @@
 		settings.ckeconfig.toolbarStartupExpanded = {$editor_toolbar_hide ? 'false' : 'true'};
 
 		// Add or remove plugins based on Rhymix configuration.
+		{@ $editor_additional_plugins[] = 'rx_upload'}
 		<!--@if($editor_additional_plugins)-->
 			settings.ckeconfig.extraPlugins = {json_encode(implode(',', $editor_additional_plugins))};
 		<!--@endif-->

From 633478710d1e283dc8b86a2de6753608d71057a6 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Wed, 24 Apr 2024 22:52:32 +0900
Subject: [PATCH 2/8] Clean up error handling code in the auto upload plugin

---
 .../ckeditor/plugins/rx_upload/plugin.js      | 25 +++++++++++++------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index a36b27000..2cd4e7395 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -1,7 +1,10 @@
+'use strict';
+
 /**
  * Upload plugin for Rhymix
  */
 CKEDITOR.plugins.add('rx_upload', {
+
 	init: function(editor) {
 
 		/**
@@ -53,11 +56,15 @@ CKEDITOR.plugins.add('rx_upload', {
 				data: form,
 				dataType: 'json',
 				success: function(data) {
-					insertFile(upload_container, data);
-					reloadFileList(upload_container, data);
+					if (data.error == 0) {
+						insertFile(upload_container, data);
+						reloadFileList(upload_container, data);
+					} else {
+						displayError(8, data.message);
+					}
 				},
 				error: function(jqXHR) {
-					alert('Upload error: ' + jqXHR.responseText);
+					displayError(9, jqXHR.responseText);
 				}
 			});
 		};
@@ -66,10 +73,6 @@ CKEDITOR.plugins.add('rx_upload', {
 		 * Insert file into editor.
 		 */
 		const insertFile = function(container, data) {
-			if (data.error != 0) {
-				alert(data.message);
-				return;
-			}
 
 			let temp_code = '';
 			if(/\.(gif|jpe?g|png|webp)$/i.test(data.source_filename)) {
@@ -112,5 +115,13 @@ CKEDITOR.plugins.add('rx_upload', {
 			container.data('instance').loadFilelist(container, true);
 		};
 
+		/**
+		 * Display an error message.
+		 */
+		const displayError = function(type, message) {
+			alert(window.xe.msg_file_upload_error + ' (Type ' + type + ")\n" + message);
+		};
+
 	}
+
 });

From bd138800bce51becf57195f10099fe3e8431d40c Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Wed, 24 Apr 2024 23:17:56 +0900
Subject: [PATCH 3/8] Unify the logic for inserting uploaded file into editor
 content

---
 .../ckeditor/plugins/rx_upload/plugin.js      |  34 +----
 .../js/plugins/jquery.fileupload/js/main.js   | 116 +++++++++---------
 2 files changed, 60 insertions(+), 90 deletions(-)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index 2cd4e7395..62391fed0 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -73,38 +73,8 @@ CKEDITOR.plugins.add('rx_upload', {
 		 * Insert file into editor.
 		 */
 		const insertFile = function(container, data) {
-
-			let temp_code = '';
-			if(/\.(gif|jpe?g|png|webp)$/i.test(data.source_filename)) {
-				temp_code += '<img src="' + data.download_url + '" alt="' + data.source_filename + '" editor_component="image_link" data-file-srl="' + data.file_srl + '" />';
-			}
-			else if(/\.(mp3|wav|ogg|flac|aac)$/i.test(data.source_filename)) {
-				temp_code += '<audio src="' + data.download_url + '" controls data-file-srl="' + data.file_srl + '" />';
-			}
-			else if(/\.(mp4|webm|ogv)$/i.test(data.source_filename)) {
-				if(data.original_type === 'image/gif') {
-					temp_code += '<video src="' + data.download_url + '" autoplay loop muted playsinline data-file-srl="' + data.file_srl + '" />';
-				} else if (data.download_url.match(/\b(?:procFileDownload\b|files\/download\/)/)) {
-					if (!data.download_url.match(/^\//)) {
-						data.download_url = XE.URI(default_url).pathname() + data.download_url;
-					}
-					temp_code += '<video src="' + data.download_url + '" controls preload="none" data-file-srl="' + data.file_srl + '" />';
-				} else {
-					temp_code += '<video src="' + data.download_url + '" controls data-file-srl="' + data.file_srl + '" />';
-				}
-				if(data.thumbnail_filename) {
-					temp_code = temp_code.replace('controls', 'poster="' + data.thumbnail_filename.replace(/^.\//, XE.URI(default_url).pathname()) + '" controls');
-				}
-			}
-			else {
-				temp_code += '<a href="' + data.download_url + '" data-file-srl="' + data.file_srl + '">' + data.source_filename + "</a>\n";
-			}
-
-			if(temp_code !== '') {
-				temp_code = "<p>" + temp_code + "</p>\n";
-			}
-
-			editor.insertHtml(temp_code, 'unfiltered_html');
+			const html = container.data('instance').generateHtml(container, data);
+			editor.insertHtml(html, 'unfiltered_html');
 		};
 
 		/**
diff --git a/common/js/plugins/jquery.fileupload/js/main.js b/common/js/plugins/jquery.fileupload/js/main.js
index d504d0284..579f93b93 100644
--- a/common/js/plugins/jquery.fileupload/js/main.js
+++ b/common/js/plugins/jquery.fileupload/js/main.js
@@ -174,36 +174,24 @@
 					}
 
 					if(result.error == 0) {
-						if(/\.(gif|jpe?g|png|webp)$/i.test(result.source_filename) && opt.autoinsertTypes.image) {
-							temp_code += '<img src="' + result.download_url + '" alt="' + result.source_filename + '" editor_component="image_link" data-file-srl="' + result.file_srl + '" />';
+						var filename = String(result.source_filename);
+						if (filename.match(/\.(gif|jpe?g|png|webp)$/i) && opt.autoinsertTypes.image) {
+							temp_code = self.generateHtml($container, result);
 						}
-						else if(/\.(mp3|wav|ogg|flac|aac)$/i.test(result.source_filename) && opt.autoinsertTypes.audio) {
-							temp_code += '<audio src="' + result.download_url + '" controls data-file-srl="' + result.file_srl + '" />';
+						else if (filename.match(/\.(mp3|wav|ogg|flac|aac)$/i) && opt.autoinsertTypes.audio) {
+							temp_code = self.generateHtml($container, result);
 						}
-						else if(/\.(mp4|webm|ogv)$/i.test(result.source_filename) && opt.autoinsertTypes.video) {
-							if(result.original_type === 'image/gif') {
-								temp_code += '<video src="' + result.download_url + '" autoplay loop muted playsinline data-file-srl="' + result.file_srl + '" />';
-							} else if (result.download_url.match(/\b(?:procFileDownload\b|files\/download\/)/)) {
-								if (!result.download_url.match(/^\//)) {
-									result.download_url = XE.URI(default_url).pathname() + result.download_url;
-								}
-								temp_code += '<video src="' + result.download_url + '" controls preload="none" data-file-srl="' + result.file_srl + '" />';
-							} else {
-								temp_code += '<video src="' + result.download_url + '" controls data-file-srl="' + result.file_srl + '" />';
-							}
-							if(result.thumbnail_filename) {
-								temp_code = temp_code.replace('controls', 'poster="' + result.thumbnail_filename.replace(/^.\//, XE.URI(default_url).pathname()) + '" controls');
-							}
+						else if (filename.match(/\.(mp4|webm|ogv)$/i) && opt.autoinsertTypes.video) {
+							temp_code = self.generateHtml($container, result);
 						}
 
 						if(temp_code !== '') {
-							if (opt.autoinsertPosition === 'paragraph') {
-								temp_code = "<p>" + temp_code + "</p>\n";
-							}
 							try {
 								_getCkeInstance(settings.formData.editor_sequence).insertHtml(temp_code, "unfiltered_html");
 							}
-							catch(err) {}
+							catch(err) {
+								// pass
+							}
 						}
 						if (typeof result.files !== 'undefined') {
 							$container.data('editorStatus', result);
@@ -353,51 +341,63 @@
 		unselectImageFiles: function() {},
 		unselectNonImageFiles: function() {},
 
+		generateHtml: function($container, file) {
+			var filename = String(file.source_filename);
+			var html = '';
+			var data = $container.data();
+
+			if (filename.match(/\.(gif|jpe?g|png|webp)$/i)) {
+				html = '<img src="' + file.download_url + '" alt="' + file.source_filename + '"'
+					+ ' editor_component="image_link" data-file-srl="' + file.file_srl + '" />';
+			}
+			else if (filename.match(/\.(mp3|wav|ogg|flac|aac)$/i)) {
+				html = '<audio src="' + file.download_url + '" controls' +
+					' data-file-srl="' + file.file_srl + '" />';
+			}
+			else if (filename.match(/\.(mp4|webm|ogv)$/i)) {
+				if (file.original_type === 'image/gif') {
+					html = '<video src="' + file.download_url + '"'
+						+ ' autoplay loop muted playsinline data-file-srl="' + file.file_srl + '" />';
+				} else if (file.download_url.match(/\b(?:procFileDownload\b|files\/download\/)/)) {
+					if (!file.download_url.match(/^\//)) {
+						file.download_url = XE.URI(default_url).pathname() + file.download_url;
+					}
+					html = '<video src="' + file.download_url + '" controls preload="none"'
+						+ ' data-file-srl="' + file.file_srl + '" />';
+				} else {
+					html = '<video src="' + file.download_url + '" controls data-file-srl="' + file.file_srl + '" />';
+				}
+				if (file.thumbnail_filename) {
+					html = html.replace('controls', 'poster="' + file.thumbnail_filename.replace(/^.\//, XE.URI(default_url).pathname()) + '" controls');
+				}
+			}
+
+			if (html !== '' && data.settings.autoinsertPosition === 'paragraph') {
+					html = '<p>' + html + '</p>\n';
+			}
+
+			if (html === '') {
+				html += '<a href="' + file.download_url + '" data-file-srl="' + file.file_srl + '">' + file.source_filename + '</a>\n';
+			}
+
+			return html;
+		},
+
 		insertToContent: function($container) {
 			var self = this;
 			var data = $container.data();
-
 			$.each(data.selected_files, function(idx, file) {
 				var file_srl = $(file).data().fileSrl;
 				var result = data.files[file_srl];
-				if(!result) return;
-				var temp_code = '';
-
-				if(/\.(gif|jpe?g|png|webp)$/i.test(result.source_filename)) {
-					temp_code += '<img src="' + result.download_url + '" alt="' + result.source_filename + '" editor_component="image_link" data-file-srl="' + result.file_srl + '" />';
-				}
-				else if(/\.(mp3|wav|ogg|flac|aac)$/i.test(result.source_filename)) {
-					temp_code += '<audio src="' + result.download_url + '" controls data-file-srl="' + result.file_srl + '" />';
-				}
-				else if(/\.(mp4|webm|ogv)$/i.test(result.source_filename)) {
-					if(result.original_type === 'image/gif') {
-						temp_code += '<video src="' + result.download_url + '" autoplay loop muted playsinline data-file-srl="' + result.file_srl + '" />';
-					} else if (result.download_url.match(/\b(?:procFileDownload\b|files\/download\/)/)) {
-						if (!result.download_url.match(/^\//)) {
-							result.download_url = XE.URI(default_url).pathname() + result.download_url;
-						}
-						temp_code += '<video src="' + result.download_url + '" controls preload="none" data-file-srl="' + result.file_srl + '" />';
-					} else {
-						temp_code += '<video src="' + result.download_url + '" controls data-file-srl="' + result.file_srl + '" />';
+				if (result) {
+					var html = self.generateHtml($container, result);
+					try {
+						_getCkeInstance(data.editorSequence).insertHtml(html, 'unfiltered_html');
 					}
-					if(result.thumbnail_filename) {
-						temp_code = temp_code.replace('controls', 'poster="' + result.thumbnail_filename.replace(/^.\//, XE.URI(default_url).pathname()) + '" controls');
+					catch(err) {
+						// pass
 					}
 				}
-
-				if(temp_code !== '') {
-					if (data.settings.autoinsertPosition === 'paragraph') {
-						temp_code = "<p>" + temp_code + "</p>\n";
-					}
-				}
-				if(temp_code === '') {
-					temp_code += '<a href="' + result.download_url + '" data-file-srl="' + result.file_srl + '">' + result.source_filename + "</a>\n";
-				}
-				try {
-					_getCkeInstance(data.editorSequence).insertHtml(temp_code, "unfiltered_html");
-				}
-				catch(err) {}
-
 			});
 		},
 		/**

From 6acd092dc642e5b4af55606f773173944949d1ce Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Wed, 24 Apr 2024 23:31:37 +0900
Subject: [PATCH 4/8] Prevent the clipboard plugin from displaying the "file
 type not supported" error for webp, mp4, and other file types

---
 .../js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index 62391fed0..5afe6ca3a 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -7,6 +7,11 @@ CKEDITOR.plugins.add('rx_upload', {
 
 	init: function(editor) {
 
+		/**
+		 * Prevent the clipboard plugin from interfering with file type support.
+		 */
+		editor.plugins.clipboard._supportedFileMatchers.unshift(function() { return true; });
+
 		/**
 		 * The main event handler for paste and drop.
 		 */

From 516fd738f2a32db3665133e55ac8cd5dc761d601 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Wed, 24 Apr 2024 23:45:57 +0900
Subject: [PATCH 5/8] Fix broken reference to xefu-container if autosave
 message appears in between

---
 .../js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index 5afe6ca3a..ce7554a6a 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -8,7 +8,7 @@ CKEDITOR.plugins.add('rx_upload', {
 	init: function(editor) {
 
 		/**
-		 * Prevent the clipboard plugin from interfering with file type support.
+		 * Prevent the clipboard plugin from displaying the "file type not supported" error.
 		 */
 		editor.plugins.clipboard._supportedFileMatchers.unshift(function() { return true; });
 
@@ -41,7 +41,7 @@ CKEDITOR.plugins.add('rx_upload', {
 
 			// Get the editor sequence.
 			const editor_container = $(editor.container.$).parents('.rx_ckeditor');
-			const upload_container = editor_container.next('.xefu-container');
+			const upload_container = editor_container.nextAll('.xefu-container').first();
 			const editor_sequence = editor_container.data('editorSequence');
 
 			// Generate the form data.

From b817b859895ebfd216d77451adcdd76608faf03d Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Thu, 25 Apr 2024 00:00:29 +0900
Subject: [PATCH 6/8] Re-disable clipboard_handleImages

---
 .../js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index ce7554a6a..147732a8d 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -8,9 +8,12 @@ CKEDITOR.plugins.add('rx_upload', {
 	init: function(editor) {
 
 		/**
-		 * Prevent the clipboard plugin from displaying the "file type not supported" error.
+		 * Prevent the clipboard plugin from interfering with us.
 		 */
 		editor.plugins.clipboard._supportedFileMatchers.unshift(function() { return true; });
+		if (editor.config.clipboard_handleImages) {
+			editor.config.clipboard_handleImages = false;
+		}
 
 		/**
 		 * The main event handler for paste and drop.

From 7dd3dd3838fb6d9f962ea0b9310b52a9f810b1b5 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Thu, 25 Apr 2024 23:19:32 +0900
Subject: [PATCH 7/8] Clean up javascript mixed with template syntax in
 file_upload.html

---
 .../editor/skins/ckeditor/file_upload.html    | 54 ++++++++++---------
 1 file changed, 30 insertions(+), 24 deletions(-)

diff --git a/modules/editor/skins/ckeditor/file_upload.html b/modules/editor/skins/ckeditor/file_upload.html
index e67763992..bcd70525d 100644
--- a/modules/editor/skins/ckeditor/file_upload.html
+++ b/modules/editor/skins/ckeditor/file_upload.html
@@ -1,10 +1,17 @@
+<config autoescape="on" />
+<load target="./lang" />
+
 <!--%load_js_plugin("jquery.fileupload")-->
 <!--%load_js_plugin("jquery.finderSelect")-->
 <!--%load_js_plugin("handlebars")-->
-<load target="./lang" />
+
 <div cond="$allow_fileupload" id="xefu-container-{$editor_sequence}" class="xefu-container xe-clearfix"
 	data-editor-sequence="{$editor_sequence}"
-	data-editor-status="{escape(json_encode(FileModel::getInstance()->getFileList($editor_sequence)))}">
+	data-editor-status="{json_encode(FileModel::getInstance()->getFileList($editor_sequence), JSON_UNESCAPED_UNICODE)}"
+	data-max-file-size="{$logged_info->is_admin === 'Y' ? 0 : $file_config->allowed_filesize}"
+	data-max-chunk-size="{$file_config->allowed_chunk_size ?: 0}"
+	data-autoinsert-types="{json_encode($editor_autoinsert_types)}"
+	data-autoinsert-position="{$editor_autoinsert_position ?: 'paragraph'}">
 
 	<!--// dropzone -->
 	<div class="xefu-dropzone">
@@ -29,10 +36,9 @@
 		<div style="float: left;">
 			{$lang->ckeditor_file_count} (<span class="attached_size"></span> / <span class="allowed_attach_size"></span>)
 		</div>
-
 		<div style="float: right">
-			<input type="button" class="xefu-btn xefu-act-link-selected" style=" vertical-align: middle; vertical-align: middle;" value="{$lang->edit->link_file}">
-			<input type="button" class="xefu-btn xefu-act-delete-selected" style=" vertical-align: middle; vertical-align: middle;" value="{$lang->edit->delete_selected}">
+			<input type="button" class="xefu-btn xefu-act-link-selected" style="vertical-align: middle" value="{$lang->edit->link_file}">
+			<input type="button" class="xefu-btn xefu-act-delete-selected" style="vertical-align: middle" value="{$lang->edit->delete_selected}">
 		</div>
 	</div>
 
@@ -41,7 +47,6 @@
 			<ul>
 			</ul>
 		</div>
-
 		<div class="xefu-list-files">
 			<ul>
 			</ul>
@@ -51,24 +56,18 @@
 </div>
 
 <script>
-	function reloadUploader(editor_sequence){
-<!--@if($allow_fileupload)-->
-		$container = jQuery('#xefu-container-' + editor_sequence);
-		$container.data('instance').loadFilelist($container);
-<!--@endif-->
-	}
-<!--@if($allow_fileupload)-->
+
 	jQuery(function($){
-		// uploader
-		var setting = {
-			maxFileSize: {$logged_info->is_admin === 'Y' ? 0 : $file_config->allowed_filesize},
-			maxChunkSize: {$file_config->allowed_chunk_size ?: 0},
-			autoinsertTypes: {json_encode($editor_autoinsert_types)},
-			autoinsertPosition: {json_encode($editor_autoinsert_position ?: 'paragraph')},
-			singleFileUploads: true
-		};
-		$container = $('#xefu-container-{$editor_sequence}');
-		$container.data('instance',$container.xeUploader(setting));
+		var container = $('#xefu-container-{$editor_sequence}');
+		if (container.length) {
+			container.data('instance', container.xeUploader({
+				maxFileSize: parseInt(container.data('maxFileSize'), 10),
+				maxChunkSize: parseInt(container.data('maxChunkSize'), 10),
+				autoinsertTypes: container.data('autoinsertTypes'),
+				autoinsertPosition: container.data('autoinsertPosition'),
+				singleFileUploads: true
+			}));
+		}
 		window.xe.msg_exceeds_limit_size = '{$lang->msg_exceeds_limit_size}';
 		window.xe.msg_checked_file_is_deleted = '{$lang->msg_checked_file_is_deleted}';
 		window.xe.msg_file_cart_is_null = '{$lang->msg_file_cart_is_null}';
@@ -76,5 +75,12 @@
 		window.xe.msg_not_allowed_filetype = '{$lang->msg_not_allowed_filetype}';
 		window.xe.msg_file_upload_error = '{$lang->msg_file_upload_error}';
 	});
-<!--@endif-->
+
+	function reloadUploader(editor_sequence) {
+		var container = $('#xefu-container-' + editor_sequence);
+		if (container.length) {
+			container.data('instance').loadFilelist($container);
+		}
+	}
+
 </script>

From b9ea0e65b048b608a05abfcd1b165dff813de612 Mon Sep 17 00:00:00 2001
From: Kijin Sung <kijin@kijinsung.com>
Date: Fri, 26 Apr 2024 13:35:20 +0900
Subject: [PATCH 8/8] General cleanup of DOM traversal code in editor &
 uploader (should also fix #2303)

---
 .../ckeditor/plugins/rx_upload/plugin.js      |  2 +-
 modules/editor/skins/ckeditor/editor.html     |  9 ++-
 .../editor/skins/ckeditor/file_upload.html    |  2 +-
 .../skins/simpleeditor/js/simpleeditor.js     |  8 +--
 modules/editor/skins/textarea/js/textarea.js  | 14 ++---
 modules/editor/tpl/js/editor.app.js           | 62 ++++++++++---------
 6 files changed, 49 insertions(+), 48 deletions(-)

diff --git a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
index 147732a8d..7af7b291d 100644
--- a/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
+++ b/common/js/plugins/ckeditor/ckeditor/plugins/rx_upload/plugin.js
@@ -43,7 +43,7 @@ CKEDITOR.plugins.add('rx_upload', {
 		const uploadFile = function(file) {
 
 			// Get the editor sequence.
-			const editor_container = $(editor.container.$).parents('.rx_ckeditor');
+			const editor_container = $(editor.container.$).closest('.rx_ckeditor');
 			const upload_container = editor_container.nextAll('.xefu-container').first();
 			const editor_sequence = editor_container.data('editorSequence');
 
diff --git a/modules/editor/skins/ckeditor/editor.html b/modules/editor/skins/ckeditor/editor.html
index b6d70cfcd..09a9d95d2 100644
--- a/modules/editor/skins/ckeditor/editor.html
+++ b/modules/editor/skins/ckeditor/editor.html
@@ -134,8 +134,7 @@
 				versionCheck: false
 			},
 			loadXeComponent: true,
-			enableToolbar: true,
-			content_field: jQuery('[name={$editor_content_key_name}]')
+			enableToolbar: true
 		};
 
 		// Add style-sheet for the WYSIWYG
@@ -219,15 +218,15 @@
 		var ckeApp = $('#ckeditor_instance_{$editor_sequence}').XeCkEditor(settings);
 
 		// Add use_editor and use_html fields to parent form.
-		var parentform = $('#ckeditor_instance_{$editor_sequence}').parents('form');
+		var parentform = $('#ckeditor_instance_{$editor_sequence}').closest('form');
 		var use_editor = parentform.find("input[name='use_editor']");
 		var use_html = parentform.find("input[name='use_html']");
-		if (use_editor.size()) {
+		if (use_editor.length) {
 			use_editor.val("Y");
 		} else {
 			parentform.append('<input type="hidden" name="use_editor" value="Y" />');
 		}
-		if (use_html.size()) {
+		if (use_html.length) {
 			use_html.val("Y");
 		} else {
 			parentform.append('<input type="hidden" name="use_html" value="Y" />');
diff --git a/modules/editor/skins/ckeditor/file_upload.html b/modules/editor/skins/ckeditor/file_upload.html
index bcd70525d..51f51ec70 100644
--- a/modules/editor/skins/ckeditor/file_upload.html
+++ b/modules/editor/skins/ckeditor/file_upload.html
@@ -79,7 +79,7 @@
 	function reloadUploader(editor_sequence) {
 		var container = $('#xefu-container-' + editor_sequence);
 		if (container.length) {
-			container.data('instance').loadFilelist($container);
+			container.data('instance').loadFilelist(container);
 		}
 	}
 
diff --git a/modules/editor/skins/simpleeditor/js/simpleeditor.js b/modules/editor/skins/simpleeditor/js/simpleeditor.js
index 84302c0b4..45dc31479 100644
--- a/modules/editor/skins/simpleeditor/js/simpleeditor.js
+++ b/modules/editor/skins/simpleeditor/js/simpleeditor.js
@@ -70,12 +70,12 @@
 
 			// Load editor info.
 			var editor = $(this);
-			var editor_sequence = editor.data('editor-sequence');
-			var content_key = editor.data('editor-content-key-name');
-			var primary_key = editor.data('editor-primary-key-name');
+			var editor_sequence = editor.data('editorSequence');
+			var content_key = editor.data('editorContentKeyName');
+			var primary_key = editor.data('editorPrimaryKeyName');
 			var insert_form = editor.closest('form');
 			var content_input = insert_form.find('input,textarea').filter('[name=' + content_key + ']');
-			var editor_height = editor.data('editor-height');
+			var editor_height = editor.data('editorHeight');
 			if (editor_height) {
 				editor.css('height', editor_height + 'px');
 			}
diff --git a/modules/editor/skins/textarea/js/textarea.js b/modules/editor/skins/textarea/js/textarea.js
index 1c477fa06..a9ca4ff0e 100644
--- a/modules/editor/skins/textarea/js/textarea.js
+++ b/modules/editor/skins/textarea/js/textarea.js
@@ -1,27 +1,27 @@
 function editorTextarea(editor_sequence) {
 	var textarea = jQuery("#textarea_instance_" + editor_sequence);
-	var content_key = textarea.data("editor-content-key-name");
-	var primary_key = textarea.data("editor-primary-key-name");
+	var content_key = textarea.data("editorContentKeyName");
+	var primary_key = textarea.data("editorPrimaryKeyName");
 	var insert_form = textarea.closest("form");
 	var content_input = insert_form.find("input[name='" + content_key + "']");
 	var content = "";
-	
+
 	// Set editor keys
     editorRelKeys[editor_sequence] = {};
     editorRelKeys[editor_sequence].primary = insert_form.find("input[name='" + primary_key + "']");
 	editorRelKeys[editor_sequence].content = content_input;
     editorRelKeys[editor_sequence].func = editorGetContent;
-	
+
 	// Set editor_sequence
 	insert_form[0].setAttribute('editor_sequence', editor_sequence);
-	
+
 	// Load existing content
 	if (content_input.size()) {
 		content = String(content_input.val()).stripTags();
 		content_input.val(content);
 		textarea.val(content.unescape());
 	}
-	
+
 	// Save edited content
 	textarea.on("change", function() {
 		content_input.val(String(jQuery(this).val()).escape());
@@ -41,4 +41,4 @@ function editorTextarea(editor_sequence) {
 		});
 		editor_resize_iframe.height(textarea.height());
 	}
-}
\ No newline at end of file
+}
diff --git a/modules/editor/tpl/js/editor.app.js b/modules/editor/tpl/js/editor.app.js
index 31dc24d16..b99fe5de9 100644
--- a/modules/editor/tpl/js/editor.app.js
+++ b/modules/editor/tpl/js/editor.app.js
@@ -1,16 +1,14 @@
 function getCkFormInstance(editor_sequence)
 {
-	var fo_obj = document.getElementById('ckeditor_instance_' + editor_sequence).parentNode;
-	while(fo_obj.nodeName != 'FORM') { fo_obj = fo_obj.parentNode; }
-	if(fo_obj.nodeName == 'FORM') return fo_obj;
-	return;
+	var form = $('#ckeditor_instance_' + editor_sequence).closest('form');
+	return form.length ? form[0] : null;
 }
 
-function getAutoSavedSrl(ret_obj, response_tags, c) {
+function getAutoSavedSrl(ret_obj) {
 	var editor_sequence = ret_obj.editor_sequence;
 	var primary_key = ret_obj.key;
 	var fo_obj = getCkFormInstance(editor_sequence);
-	
+
 	if(ret_obj.document_srl !== 0)
 	{
 		fo_obj[primary_key].value = ret_obj.document_srl;
@@ -76,46 +74,48 @@ function getAutoSavedSrl(ret_obj, response_tags, c) {
 		editorInit : function(containerEl, opts) {
 			var self = this;
 			var $containerEl = containerEl;
-			var $form     = $containerEl.closest('form');
-			var $contentField = $form.find(opts.content_field);
+			var form = $containerEl.closest('form');
 			var data = $containerEl.data();
-			var editor_sequence = $containerEl.data().editorSequence;
-			var primary_key = $containerEl.data().editorPrimaryKeyName;
+			var editor_sequence = data.editorSequence;
+			var primary_key = data.editorPrimaryKeyName;
+			var primary_input = form.find("[name='" + primary_key + "']");
+			var content_key = data.editorContentKeyName;
+			var content_input = form.find("[name='" + content_key + "']");
 			var fo_obj = getCkFormInstance(editor_sequence);
 
 			this.ckeconfig = $.extend({}, default_ckeconfig, opts.ckeconfig || {});
 			this.ckeconfig.bodyClass = this.ckeconfig.bodyClass + ' color_scheme_' + getColorScheme() +
 				($('body').hasClass('cke_auto_dark_mode') ? ' cke_auto_dark_mode' : '');
 
-			this.editor_sequence = data.editorSequence;
-			$form.attr('editor_sequence', data.editorSequence);
+			this.editor_sequence = editor_sequence;
+			form.attr('editor_sequence', editor_sequence);
 
 			if(CKEDITOR.env.mobile) CKEDITOR.env.isCompatible = true;
-			
+
 			// saved document(자동저장 문서)에 대한 확인
 			if(typeof(fo_obj._saved_doc_title)!= "undefined") { ///<< _saved_doc_title field가 없으면 자동저장 하지 않음
 				var saved_title = fo_obj._saved_doc_title.value;
 				var saved_content = fo_obj._saved_doc_content.value;
-		
+
 				if(saved_title || saved_content) {
 					// 자동저장된 문서 활용여부를 물은 후 사용하지 않는다면 자동저장된 문서 삭제
-					if(confirm(fo_obj._saved_doc_message.value)) {
-						if(typeof(fo_obj.title)!='undefined') fo_obj.title.value = saved_title;
-						$contentField.val(saved_content);
-		
-						var param = [];
-						param.editor_sequence = editor_sequence;
-						param.primary_key = primary_key;
-						param.mid = current_mid;
-						var response_tags = new Array("error","message","editor_sequence","key","title","content","document_srl");
-						exec_xml('editor',"procEditorLoadSavedDocument", param, getAutoSavedSrl, response_tags);
+					if (confirm(fo_obj._saved_doc_message.value)) {
+						if(typeof(fo_obj.title) !== 'undefined') {
+							fo_obj.title.value = saved_title;
+						}
+						content_input.val(saved_content);
+						exec_json('editor.procEditorLoadSavedDocument', {
+							editor_sequence: editor_sequence,
+							primary_key: primary_key,
+							mid: current_mid
+						}, getAutoSavedSrl);
 					} else {
 						editorRemoveSavedDoc();
 					}
 				}
 			}
 
-			var instance = CKEDITOR.appendTo($containerEl[0], {}, $contentField.val());
+			var instance = CKEDITOR.appendTo($containerEl[0], {}, content_input.val());
 
 			instance.on('customConfigLoaded', function(e) {
 				instance.config = $.extend({}, e.editor.config, self.ckeconfig);
@@ -173,17 +173,19 @@ function getAutoSavedSrl(ret_obj, response_tags, c) {
 			$containerEl.data('cke_instance', instance);
 
 			window.editorRelKeys[data.editorSequence] = {};
-			window.editorRelKeys[data.editorSequence].primary   = $form.find('[name='+data.editorPrimaryKeyName+']')[0];
-			window.editorRelKeys[data.editorSequence].content   = $form.find('[name='+data.editorContentKeyName+']')[0];
-			window.editorRelKeys[data.editorSequence].func      = function(seq) {
+			window.editorRelKeys[data.editorSequence].primary = primary_input[0];
+			window.editorRelKeys[data.editorSequence].content = content_input[0];
+			window.editorRelKeys[data.editorSequence].func = function(seq) {
 				return self.getContent.call(self, seq);
 			};
 			window.editorRelKeys[data.editorSequence].pasteHTML = function(text){
 				instance.insertHtml(text, 'html');
 			};
-			
+
 			// 자동저장 필드가 있다면 자동 저장 기능 활성화
-			if(typeof(fo_obj._saved_doc_title)!="undefined" ) editorEnableAutoSave(fo_obj, editor_sequence);
+			if (typeof(fo_obj._saved_doc_title) !== 'undefined') {
+				editorEnableAutoSave(fo_obj, editor_sequence);
+			}
 		},
 		getContent : function(seq) {
 			var self = this;