From 73e153be601f42f19aa9e2024c34d2e9c7b81c6c Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Fri, 27 Feb 2026 20:46:32 +0900 Subject: [PATCH 1/5] Fix warnings when logged_info is false #2680 --- modules/comment/comment.item.php | 29 ++++++++++++++++++----------- modules/document/document.item.php | 20 ++++++++++---------- 2 files changed, 28 insertions(+), 21 deletions(-) diff --git a/modules/comment/comment.item.php b/modules/comment/comment.item.php index 30508fc69..fd519466b 100644 --- a/modules/comment/comment.item.php +++ b/modules/comment/comment.item.php @@ -112,15 +112,15 @@ class CommentItem extends BaseObject } $logged_info = Context::get('logged_info'); - if (!$logged_info->member_srl) + if (!$logged_info || !$logged_info->member_srl) { return $this->grant_cache = false; } - if ($logged_info->is_admin == 'Y') + if ($logged_info && $logged_info->is_admin == 'Y') { return $this->grant_cache = true; } - if ($this->get('member_srl') && abs($this->get('member_srl')) == $logged_info->member_srl) + if ($logged_info && $this->get('member_srl') && abs($this->get('member_srl')) == $logged_info->member_srl) { return $this->grant_cache = true; } @@ -292,7 +292,7 @@ class CommentItem extends BaseObject // return if the currently logged-in user is an author of the comment. $logged_info = Context::get('logged_info'); - if($logged_info->member_srl == $this->get('member_srl')) + if($logged_info && $logged_info->member_srl && $logged_info->member_srl == abs($this->get('member_srl'))) { return; } @@ -306,7 +306,7 @@ class CommentItem extends BaseObject $title .= cut_str(strip_tags($content), 30, '...'); $content = sprintf('%s

from : %s', $content, getFullUrl('', 'document_srl', $this->get('document_srl')), $this->get('comment_srl'), getFullUrl('', 'document_srl', $this->get('document_srl'))); $receiver_srl = $this->get('member_srl'); - $sender_member_srl = $logged_info->member_srl; + $sender_member_srl = ($logged_info && $logged_info->member_srl) ? $logged_info->member_srl : $this->get('member_srl'); // send a message $oCommunicationController = getController('communication'); @@ -376,17 +376,24 @@ class CommentItem extends BaseObject function getMyVote() { - if(!$this->comment_srl) return false; - if(isset($_SESSION['voted_comment'][$this->comment_srl])) + if (!$this->comment_srl) + { + return false; + } + + if (isset($_SESSION['voted_comment'][$this->comment_srl])) { return $_SESSION['voted_comment'][$this->comment_srl]; } $logged_info = Context::get('logged_info'); - if(!$logged_info->member_srl) return false; + if (!$logged_info || !$logged_info->member_srl) + { + return false; + } $args = new stdClass(); - if($logged_info->member_srl) + if ($logged_info && $logged_info->member_srl) { $args->member_srl = $logged_info->member_srl; } @@ -413,7 +420,7 @@ class CommentItem extends BaseObject } $logged_info = Context::get('logged_info'); - if (!$logged_info->member_srl) + if (!$logged_info || !$logged_info->member_srl) { return false; } @@ -424,7 +431,7 @@ class CommentItem extends BaseObject } $args = new stdClass(); - if ($logged_info->member_srl) + if ($logged_info && $logged_info->member_srl) { $args->member_srl = $logged_info->member_srl; } diff --git a/modules/document/document.item.php b/modules/document/document.item.php index 4d60f1795..d883363aa 100644 --- a/modules/document/document.item.php +++ b/modules/document/document.item.php @@ -201,11 +201,11 @@ class DocumentItem extends BaseObject { return $this->grant_cache = false; } - if ($logged_info->is_admin == 'Y') + if ($logged_info && $logged_info->is_admin == 'Y') { return $this->grant_cache = true; } - if ($this->get('member_srl') && abs($this->get('member_srl')) == $logged_info->member_srl) + if ($logged_info && $this->get('member_srl') && abs($this->get('member_srl')) == $logged_info->member_srl) { return $this->grant_cache = true; } @@ -411,7 +411,7 @@ class DocumentItem extends BaseObject // Return if the currently logged-in user is an author $logged_info = Context::get('logged_info'); - if($logged_info->member_srl == $this->get('member_srl')) + if($logged_info && $logged_info->member_srl && $logged_info->member_srl == abs($this->get('member_srl'))) { return; } @@ -421,7 +421,7 @@ class DocumentItem extends BaseObject $content = sprintf('%s

from : %s',$content, getFullUrl('', 'document_srl', $this->document_srl), getFullUrl('', 'document_srl', $this->document_srl)); // Send a message - $sender_member_srl = $logged_info->member_srl ?: $this->get('member_srl'); + $sender_member_srl = ($logged_info && $logged_info->member_srl) ? $logged_info->member_srl : $this->get('member_srl'); getController('communication')->sendMessage($sender_member_srl, $this->get('member_srl'), $title, $content, false, null, false); } @@ -514,17 +514,17 @@ class DocumentItem extends BaseObject } $logged_info = Context::get('logged_info'); - if(!$logged_info->member_srl) + if (!$logged_info || !$logged_info->member_srl) { $module_info = ModuleModel::getModuleInfoByModuleSrl($this->get('module_srl')); - if($module_info->non_login_vote !== 'Y') + if(!isset($module_info->non_login_vote) || $module_info->non_login_vote !== 'Y') { return false; } } $args = new stdClass; - if($logged_info->member_srl) + if ($logged_info && $logged_info->member_srl) { $args->member_srl = $logged_info->member_srl; } @@ -554,7 +554,7 @@ class DocumentItem extends BaseObject } $logged_info = Context::get('logged_info'); - if(!$logged_info->member_srl) + if(!$logged_info || !$logged_info->member_srl) { return false; } @@ -565,7 +565,7 @@ class DocumentItem extends BaseObject } $args = new stdClass(); - if($logged_info->member_srl) + if($logged_info && $logged_info->member_srl) { $args->member_srl = $logged_info->member_srl; } @@ -1027,7 +1027,7 @@ class DocumentItem extends BaseObject // Cache the vote log for all comments. $logged_info = Context::get('logged_info'); - if ($logged_info->member_srl) + if ($logged_info && $logged_info->member_srl) { $comment_srls = array(); foreach ($comment_list as $comment_srl => $comment) From 798b0cd1d61a31ee9d92beede0e2e05d69eeb821 Mon Sep 17 00:00:00 2001 From: Kijin Sung Date: Fri, 27 Feb 2026 20:46:49 +0900 Subject: [PATCH 2/5] Fix warnings when user is logged out #2680 --- layouts/xedition/layout.html | 2 +- modules/spamfilter/spamfilter.model.php | 4 ++-- widgets/login_info/skins/ncenter_login/login_form.html | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/layouts/xedition/layout.html b/layouts/xedition/layout.html index 7892e5502..b6de9c378 100644 --- a/layouts/xedition/layout.html +++ b/layouts/xedition/layout.html @@ -209,7 +209,7 @@ {$lang->cmd_search} -
  • +
  • {$lang->cmd_management}
  • diff --git a/modules/spamfilter/spamfilter.model.php b/modules/spamfilter/spamfilter.model.php index 379cf776c..32655e094 100644 --- a/modules/spamfilter/spamfilter.model.php +++ b/modules/spamfilter/spamfilter.model.php @@ -222,11 +222,11 @@ class SpamfilterModel extends Spamfilter { return false; } - if ($user->is_admin === 'Y') + if ($user && $user->is_admin === 'Y') { return false; } - if ($config->captcha->target_users !== 'everyone' && $user->member_srl) + if ($config->captcha->target_users !== 'everyone' && $user && $user->member_srl) { return false; } diff --git a/widgets/login_info/skins/ncenter_login/login_form.html b/widgets/login_info/skins/ncenter_login/login_form.html index cd134aa97..39bb96622 100644 --- a/widgets/login_info/skins/ncenter_login/login_form.html +++ b/widgets/login_info/skins/ncenter_login/login_form.html @@ -5,7 +5,7 @@ -